agent: fix request merging when comment is missing #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osnyx
approved these changes
Aug 11, 2023
dpausp
force-pushed
the
PL-131698-agent-fix-request-merge
branch
2 times, most recently
from
6fff718
to
a121850
Compare
Don't fail merging when the first request doesn't have an explicity set comment or estimate. Also put newlines between merged comments and use the other estimate if the original request had no explicit estimate set. PL-131698
dpausp
force-pushed
the
PL-131698-agent-fix-request-merge
branch
from
a121850
to
27809b8
Compare
|
I pushed a change after the approval but it's just the same behaviour as for comments applied to estimates. Also added tests which cover the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't fail merging when the first request doesn't have an explicity set comment. Also put newlines between merged comments.
PL-131698
@flyingcircusio/release-managers
Release process
Impact:
Changelog:
Security implications