-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working since 1.1.2 ? #30
Comments
@BrodrickChilds 1.2.0 just upgrade React from 15.6 to 16.2, and remove string refs, 1.3.0 fix some issues, just like: crop will get real image size, which was wrong all the time before this version. |
@BrodrickChilds can you provide a demo to show this error? |
Hey @jerryshew this is an example of what I meant: It could very well be that we just optimized for the version in 1.1.2 but if you have any idea what might be causing this behaviour, using the latest version is obviously preferable :) |
@BrodrickChilds can you show me how you use this component?
|
Is there any update on this issue ? I was able to reproduce this in 1.3 |
Whoops! Totally forgot about this. The way we're using it is with raw photo date like such:
I figured that maybe it's hitting us because we're using it immediately after uploading a photo instead of on a photo existing online somewhere, so we just froze our version at 1.1.2 |
@jerryshew ^ |
It seems there was some kind of breaking change since 1.1.2 for us. We updated our node modules recently and since 1.1.2 it's not been possible to drag the selection area around the image, and the selection area just shows a weirdly squashed or distorted version of the full image. Does anybody know what change might have broken this behaviour for us? In the meantime just fixing the version to 1.1.2 has solved our problem.
(Another breaking behaviour is it started to give us height and width in % rather than values)
The text was updated successfully, but these errors were encountered: