Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working since 1.1.2 ? #30

Open
BrodrickChilds opened this issue Jan 30, 2018 · 7 comments
Open

Not working since 1.1.2 ? #30

BrodrickChilds opened this issue Jan 30, 2018 · 7 comments

Comments

@BrodrickChilds
Copy link

It seems there was some kind of breaking change since 1.1.2 for us. We updated our node modules recently and since 1.1.2 it's not been possible to drag the selection area around the image, and the selection area just shows a weirdly squashed or distorted version of the full image. Does anybody know what change might have broken this behaviour for us? In the meantime just fixing the version to 1.1.2 has solved our problem.

(Another breaking behaviour is it started to give us height and width in % rather than values)

@flyfloor
Copy link
Owner

@BrodrickChilds 1.2.0 just upgrade React from 15.6 to 16.2, and remove string refs, 1.3.0 fix some issues, just like: crop will get real image size, which was wrong all the time before this version.

@flyfloor
Copy link
Owner

@BrodrickChilds can you provide a demo to show this error?

@BrodrickChilds
Copy link
Author

Hey @jerryshew this is an example of what I meant:
https://imgur.com/TCa6JSs

It could very well be that we just optimized for the version in 1.1.2 but if you have any idea what might be causing this behaviour, using the latest version is obviously preferable :)

@flyfloor
Copy link
Owner

flyfloor commented Feb 2, 2018

@BrodrickChilds can you show me how you use this component?
just like:

<Cropper 
    src="http://braavos.me/images/posts/college-rock/the-smiths.png" 
    ref={ ref => { this.cropper = ref }}
/>

@codeVerine
Copy link

Is there any update on this issue ? I was able to reproduce this in 1.3

@BrodrickChilds
Copy link
Author

Whoops! Totally forgot about this.

The way we're using it is with raw photo date like such:

{ values.photoInfo && values.photoInfo.raw && <Cropper src={values.photoInfo.raw} ref="cropper" /> }

I figured that maybe it's hitting us because we're using it immediately after uploading a photo instead of on a photo existing online somewhere, so we just froze our version at 1.1.2

@BrodrickChilds
Copy link
Author

@jerryshew ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants