Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a32nx/fcu): use mach * 100 for selected mach set event #9884

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

lukecologne
Copy link
Member

Fixes #9881

Summary of Changes

Use Mach * 100 for the FCU_SPD_SET event. As SimConnect event parameters are integers, we have to use this convention to send decimals.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@lukecologne
Copy link
Member Author

lukecologne commented Mar 2, 2025

Tested by myself, and works as intended when using the event both in SPD and Mach mode. As it's a very small change I'd say it's fine to merge

@lukecologne lukecologne merged commit 77209b6 into flybywiresim:master Mar 2, 2025
8 checks passed
@lukecologne lukecologne deleted the mach-sel-set-fix branch March 2, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

FCU_SPD_SET event not working as expected
2 participants