feat(a380x/vd): Vertical display basic implementation #9831

flogross89 · 2025-02-06T00:47:32Z

Fixes #8728
Fixes #9236

Summary of Changes

Adds an implementation of the vertical display which can be expanded by other contributors
Scope of this PR:

Out of scope (ideas for future PRs):

ECAM faults for TERR/GPWS
Level-off segments / dashed line when AFS CP altitude limiting climb or descend path
Radio altimeter altitude visualization
Safety altitudes
Manual AZIM mode
Different TAWS RNP values, using 1nm for now
Symbol for "not valid pitch attitude" (yellow dot, ATT marker)
Holding patterns
FLS beams

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

You will need a special SimBridge build to test the terrain functionality of the VD: https://we.tl/t-zb8uCnKKPZ

Further test instructions coming soon.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, find and click on the PR Build tab
Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

# Conflicts: # fbw-a380x/src/systems/systems-host/index.ts

alexr4339 · 2025-02-26T20:46:40Z

Gave it an initial test.

First initial impressions. Superb update and adds some serious value but needs some finetuning

Departed KFLL 10L with a GW of 400T. Right after departure VNAV/VD recaculated the profile way above the aircraft. I think the reason may be that the profile is drawn from the runway beginning but you do lift of at the end which will give a vertical diffeence

Another point I noticed is that the terrain map does not really update when flying many circles:

After turning off and on

And for some reason druing vectoring VD has drawn the runway but only temporarily, around half a minute later it disappeared

And in cases where you are behind the completed fplan VD draws a line straight down from present alt

And it seems as if the approach path doesnt quite match towards the runway

BravoMike99 · 2025-02-27T21:45:35Z

fbw-a380x/src/systems/instruments/src/ND/VerticalDisplay/VerticalDisplay.tsx

+      if (mode === VerticalMode.ALT_CST || mode === VerticalMode.ALT_CST_CPT || altCstr) {
+        return '#ff94ff';
+      } else if (
+        mode === VerticalMode.FINAL ||


There's no FINAL on the A380 although I guess it could replace APP-DES

Yep, but I didn't want to touch this enum here, should be done as part of a bigger FG PR. How about keeping it here to have a reminder on what to change if someone decides to implement F-GS and F-LOC (we don't have APP-DES in the a380)

fbw-a380x/src/systems/instruments/src/ND/VerticalDisplay/VerticalDisplay.tsx

# Conflicts: # fbw-a380x/src/systems/failures/src/a380.ts # fbw-a380x/src/systems/systems-host/index.ts

tracernz

The VD terr should go inop in polar regions.

fbw-common/src/systems/shared/src/simbridge/Taws/taws.ts

tracernz · 2025-02-28T03:59:44Z

fbw-a380x/src/systems/systems-host/systems/EfisTawsBridge.ts

+            });
+
+      const data: ElevationSamplePathDto = {
+        pathWidth: 1,


Not implemented? Should be 1 NM in takeoff and terminal, 2 NM in enroute, and <= 0.5 NM on approach.
-e- You could add a FIXME for later ofc.

Yep, listed it in the "out of scope" list as "Different TAWS RNP values, using 1nm for now". I'll add a FIXME, needs more verification in SimBridge.

.. And the logic is a lot more complicated, depends on EPU, FMS RNP, predicted RNP, standard TAWS RNP, depending on what we're sampling

tracernz · 2025-02-28T04:01:45Z

fbw-common/src/systems/shared/src/publishers/AdiruBusPublisher.ts

+
+interface AdiruBusBaseEvents {
+  /** Raw Arinc 429 word. */
+  a32nx_adiru_true_track: number;


Suggested change

a32nx_adiru_true_track: number;

a32nx_ir_true_track: number;

IR and ADR have separate bus outputs, and further they are actually separate computers that talk to each other over ARINC429. The publishers should be arranged around output busses. Thew JSDoc should also specify what data is contained within.

Ok, I renamed the file to IrBusPublisher.ts and changed everything accordingly. Didn't all of the IR outputs though, only the one I need for now. The PR is massive as it is right now...

tracernz · 2025-02-28T04:02:48Z

fbw-common/src/systems/shared/src/publishers/AdiruBusPublisher.ts

+type IndexedTopics = 'a32nx_adiru_true_track';
+
+type AdiruBusIndexedEvents = {
+  [P in keyof Pick<AdiruBusBaseEvents, IndexedTopics> as IndexedEventType<P>]: AdiruBusBaseEvents[P];


The ADR and IR bus publishers should use a more restrained type that retricts the indices to 1 | 2 | 3. The ADR bus publisher in https://github.com/flybywiresim/aircraft/pull/9659/files#diff-a52ba40e0f76f9fd77751641600f0b1b599c203bc4c018fa4c2515db0065a3ef might be a good reference.

For the topic definitions I largely copy-pasted the a320-simvars.md content and used multi-cursor mode in VSCode to edit it into the desired format.

added as well

BlueberryKing · 2025-02-28T10:30:41Z

fbw-a32nx/src/systems/fmgc/src/guidance/lnav/PathVector.ts

@@ -44,6 +45,13 @@ export interface DebugPointPathVector {

 export type PathVector = LinePathVector | ArcPathVector | DebugPointPathVector;

+export interface VerticalPathCheckpoint {


Should this really be in this file? Is this related to path vectors?

It doesn't belong to the a32nx specific defs (hence I'll remove it here), but I think it should be present in fbw-common's PathVector. It's relevant for the vertical path transmission, IMO PathVector.ts could also cover vertical aspects, not only lateral. What's your proposal?

In my branch, I had made the vertical path sending completely separate. And enables via an FMS config option

I think there are a lot of nice synergies when combining the lateral and vertical path transmission. Maybe in the future it makes sense to de-couple this, when we want to improve the prediction of vertical paths for selected modes, amongst other necessary improvements.

flogross89 · 2025-03-01T02:13:32Z

The VD terr should go inop in polar regions.

Ah yeah totally, also made that check in the VD for displaying the flag, but it should be at the place where the failure conditions are checked, which is EfisTawsBridge. Moved it there.

flogross89 · 2025-03-01T02:33:17Z

@alexr4339 About "behind FPLN line straight down": Couldn't reproduce it

But I'm very sure that we are going to have problems with matching our position to existing trajctories, it's a very tricky problem doing this right. We might have to keep improvements on that for later.

alexr4339 · 2025-03-01T22:20:48Z

Test run 2 using 6982c8b:

Issues:
Colors still seem too bright
I would suggest HEX: 626272 for now. Should be much closer to the following ref:

Grey area incorrectly drawn:

In this case there should be no grey area, as fplan and track match up.
Interesting was, that this issue only happened on the capt side, FO side displayed grey area correctly

Another note: See that simbridge has still drawn TERR on ND, even though I just recently turned TERR off

VD didnt match VNAV

See that VD started a descent from PPOS, while VNAV predicted the decent later on. Would expect VD to draw a horizontal line and start the descent at the point displayed by the arrow.

The VD grey zone should darker the TERR as well, which it currently doesnt

What did I do?
Fplan:
CYOW/14 N0477F380 DCT TUKIR IMEBA9 CYYZ/33R
Did a pretty much routine flight, departed, went direct TUKIR, climbed to my cruise alt of FL200, initiated the descent at TOD marker and flew a standard ILS and select a DTO towards the waypoint before the FAF in cruise

flogross89 · 2025-03-02T00:51:44Z

@alexr4339 Why are you saying it's "still" too dark? I thought it was too bright before? In your ref image the exposure was pretty low due to a lot of ambient light. In other refs the area looks way brighter. Let's go with #4e4e61 for now, and re-evaluate after merging or when we have more data points.

About the grey area: I might have to debug that further.

TERR still on ND even if TERR is off: Most likely also a SimBridge cycle refresh issue, can't/won't fix that in this PR.

VD didn't match VNAV: Seems like the T/D pseudo waypoint didn't get considered, I'll see whether I'm missing something.

flogross89 · 2025-03-02T01:43:23Z

@flogross89 Just updated the SimBridge build with the new colors

alexr4339 · 2025-03-02T09:27:56Z

@flogross89 apologies, meant too bright for sure. I'll re-evaluate once with the new simbridge build!

flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft ND (Navigation Display) EFIS Issue is related to the EFIS labels Feb 6, 2025

flogross89 added this to the v0.13.0 milestone Feb 6, 2025

flogross89 marked this pull request as draft February 6, 2025 00:54

flogross89 added 9 commits February 7, 2025 17:56

subscription cleanup

94b8890

WASM prep; TODO: fill path data

8207683

some preparation

2473d9e

some basics

05fe4bd

some more stuff

2ed3219

sub cleanup

b8a4d8d

symbols

1b0eb27

draw constraints

937f11c

correct airport shape

c06aac1

flogross89 force-pushed the feat-a380x-vd-basics branch from c7f6300 to c06aac1 Compare February 7, 2025 16:15

flogross89 added 14 commits February 8, 2025 06:42

more WIP

05eefff

end of VD marker

435aa17

Merge branch 'master' into feat-a380x-vd-basics

3d6c630

undo SimConnect changes

7da3102

remove unused

85d243d

add linebreak

365105f

EfisTawsBridge

3680510

works now

29feefd

Merge branch 'master' into feat-a380x-vd-basics

4349701

format & add terrOnNd & terronVd

ac90c9a

transmit fms path from EfisTawsBridge

27761b5

Merge branch 'master' into feat-a380x-vd-basics

05d4a35

# Conflicts: # fbw-a380x/src/systems/systems-host/index.ts

improve selected path

a046ce3

taws stuff

b0d0691

flogross89 added 8 commits February 17, 2025 02:18

fix one more import

b4d9fd7

mode change takes priority for VD

80c5b86

stricter imports

bca9fff

maybe this

b22094e

refactor VdSimvarPublisher

ece5221

remove/refactor EfisTawsBridgePublisher

8e8fc48

react to GPWS failure

ccba336

fix when fmsPath is null

05b44d7

flogross89 force-pushed the feat-a380x-vd-basics branch from 19a987a to 05b44d7 Compare February 17, 2025 23:40

flogross89 requested review from Benjozork and tracernz February 17, 2025 23:41

flogross89 added 2 commits February 19, 2025 00:35

use same mode/range change priority as ND

d18b4fb

Merge branch 'master' into feat-a380x-vd-basics

e89180f

BravoMike99 reviewed Feb 27, 2025

View reviewed changes

Merge branch 'master' into feat-a380x-vd-basics

4f60a25

# Conflicts: # fbw-a380x/src/systems/failures/src/a380.ts # fbw-a380x/src/systems/systems-host/index.ts

tracernz reviewed Feb 28, 2025

View reviewed changes

BlueberryKing reviewed Feb 28, 2025

View reviewed changes

flogross89 added 2 commits March 1, 2025 01:44

review comments round 1

28acc29

add JSdoc; move extreme latitude check from VD flag to EfisTawsBridge

f218645

flogross89 added 2 commits March 1, 2025 07:40

change colors

dae8bfd

refine grey segment and end of VD marker logic

6982c8b

flogross89 force-pushed the feat-a380x-vd-basics branch from 3c04129 to 6982c8b Compare March 1, 2025 05:45

Merge branch 'master' into feat-a380x-vd-basics

ff9c63c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(a380x/vd): Vertical display basic implementation #9831

feat(a380x/vd): Vertical display basic implementation #9831

flogross89 commented Feb 6, 2025 •

edited

Loading

alexr4339 commented Feb 26, 2025 •

edited

Loading

BravoMike99 Feb 27, 2025

flogross89 Feb 28, 2025

tracernz left a comment

tracernz Feb 28, 2025 •

edited

Loading

flogross89 Feb 28, 2025

flogross89 Feb 28, 2025

tracernz Feb 28, 2025 •

edited

Loading

flogross89 Feb 28, 2025

tracernz Feb 28, 2025 •

edited

Loading

flogross89 Feb 28, 2025

BlueberryKing Feb 28, 2025

flogross89 Feb 28, 2025

Benjozork Feb 28, 2025

flogross89 Feb 28, 2025

flogross89 commented Mar 1, 2025

flogross89 commented Mar 1, 2025

alexr4339 commented Mar 1, 2025 •

edited

Loading

flogross89 commented Mar 2, 2025

flogross89 commented Mar 2, 2025

alexr4339 commented Mar 2, 2025

		@@ -44,6 +45,13 @@ export interface DebugPointPathVector {

		export type PathVector = LinePathVector \| ArcPathVector \| DebugPointPathVector;

		export interface VerticalPathCheckpoint {

feat(a380x/vd): Vertical display basic implementation #9831

Are you sure you want to change the base?

feat(a380x/vd): Vertical display basic implementation #9831

Conversation

flogross89 commented Feb 6, 2025 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

alexr4339 commented Feb 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tracernz left a comment

Choose a reason for hiding this comment

tracernz Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tracernz Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tracernz Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flogross89 commented Mar 1, 2025

flogross89 commented Mar 1, 2025

alexr4339 commented Mar 1, 2025 • edited Loading

flogross89 commented Mar 2, 2025

flogross89 commented Mar 2, 2025

alexr4339 commented Mar 2, 2025

flogross89 commented Feb 6, 2025 •

edited

Loading

alexr4339 commented Feb 26, 2025 •

edited

Loading

tracernz Feb 28, 2025 •

edited

Loading

tracernz Feb 28, 2025 •

edited

Loading

tracernz Feb 28, 2025 •

edited

Loading

alexr4339 commented Mar 1, 2025 •

edited

Loading