Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/pfd): add LS reminder indicator #9668

Merged
merged 13 commits into from
Feb 26, 2025

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Dec 16, 2024

Fixes #[issue_no]

Summary of Changes

Adds xLS reminder on the PFD

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

  1. Select an ILS approach/tune ILS frequency in the MCDU.
  2. press LOC or APPR on the FCU such that LOC or LOC/G/S arm or activate. Verify purple ILS appears on the bottom right of PFD without blinking.
    3.1) Deselect the LS button on either side through the EFIS control panel. Amber "LS" should appear blinking on the associated PFD side and stop after 9 seconds.
  3. Once LS button is pushed on the associated side, the amber indication disappears.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BravoMike99 BravoMike99 force-pushed the pfd-ls-reminder branch 2 times, most recently from ac16efd to 380161e Compare December 17, 2024 22:15
@BravoMike99 BravoMike99 marked this pull request as ready for review December 17, 2024 22:35
@BravoMike99 BravoMike99 added A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft labels Dec 17, 2024
@G-DRAW
Copy link

G-DRAW commented Dec 18, 2024

Aircraft Version
Stable

Build info
"v0.12.0"
Describe the bug
When doing an ILS approach in the A380, and the LS P/B's on EFIS is not turned ON, the LS will constantly flash in amber which is correct, but doesn't automatically display the lateral and vertical deviation scales when LOC or APPR Mode is armed.

Expected behavior
If LS P/B isn't selected when doing an ILS approach, it would automatically display the LOC and G/S deviation scales on both PFD's after arming the LOC P/B or APPR P/B, and the LS P/B's would automatically light up.
Landing System Scales
Landing System Scales

Steps to reproduce
Setup an ILS approach anywhare you want and conduct approach.
leave LS P/B's off.
Check that amber LS is flashing when getting nearer to runway.
ARM LOC P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS.
Deselect LOC
Also turn off LS P/B's on both EFIS.
Check that amber LS is flashing when getting nearer to runway.
ARM APPR P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS.

For A320 it's different.

@BravoMike99
Copy link
Contributor Author

Aircraft Version Stable

Build info "v0.12.0" Describe the bug When doing an ILS approach in the A380, and the LS P/B's on EFIS is not turned ON, the LS will constantly flash in amber which is correct, but doesn't automatically display the lateral and vertical deviation scales when LOC or APPR Mode is armed.

Expected behavior If LS P/B isn't selected when doing an ILS approach, it would automatically display the LOC and G/S deviation scales on both PFD's after arming the LOC P/B or APPR P/B, and the LS P/B's would automatically light up. Landing System Scales Landing System Scales

Steps to reproduce Setup an ILS approach anywhare you want and conduct approach. leave LS P/B's off. Check that amber LS is flashing when getting nearer to runway. ARM LOC P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS. Deselect LOC Also turn off LS P/B's on both EFIS. Check that amber LS is flashing when getting nearer to runway. ARM APPR P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS.

For A320 it's different.

The original purpose of this PR is to just add the LS indicator on the PFD. The automatic LS selection is left for future work and should be addressed in a further PR.

@BravoMike99 BravoMike99 force-pushed the pfd-ls-reminder branch 2 times, most recently from 826bab9 to 1ce1234 Compare December 30, 2024 14:55
@BravoMike99 BravoMike99 force-pushed the pfd-ls-reminder branch 2 times, most recently from 7376d78 to fc6ad69 Compare January 29, 2025 23:25
@BravoMike99 BravoMike99 added QA Tier 1 QA A380 Only QA only for A380 required QA Ready to Test and removed A32NX Related to the A32NX aircraft labels Feb 13, 2025
@BravoMike99 BravoMike99 changed the title feat(pfd): add LS reminder indicator feat(a380x/pfd): add LS reminder indicator Feb 13, 2025
@Jaronics
Copy link

Quality Assurance Trainee Report

Discord Username : Jaronics
Object of testing : #9668
Aircraft : A380X
Tier of Testing : 1
Date : 14/02/2025

Testing Process:

  1. Spawned on the runway. LS was displayed in amber when spawning and didn't go away when selecting the LS buttons to on. They layered over each other. (picture attached)
  2. This issue could be fixed when turning on the APP button once in the air and letting the LS buttons turn on automatically.
    2.1 Tried again, spawning at a gate. Issue still persists.
  3. Armed APPROACH mode as normal and manually turned off the LS buttons. LS began to flash for 9sec.
  4. Turned on the LS buttons manually. Amber LS disappeared correctly and was exchanged with the normal LS indications.

Testing Results:
Not Passed

Negatives:
Layering of the two indications on the ground needs to be looked into.

Conclusions:
PR performed as expected, except the issue when spawning in.

Media:
Screenshot 2025-02-14 214330

@BravoMike99
Copy link
Contributor Author

BravoMike99 commented Feb 15, 2025

Quality Assurance Trainee Report

Discord Username : Jaronics Object of testing : #9668 Aircraft : A380X Tier of Testing : 1 Date : 14/02/2025

Testing Process:

  1. Spawned on the runway. LS was displayed in amber when spawning and didn't go away when selecting the LS buttons to on. They layered over each other. (picture attached)
  2. This issue could be fixed when turning on the APP button once in the air and letting the LS buttons turn on automatically.
    2.1 Tried again, spawning at a gate. Issue still persists.
  3. Armed APPROACH mode as normal and manually turned off the LS buttons. LS began to flash for 9sec.
  4. Turned on the LS buttons manually. Amber LS disappeared correctly and was exchanged with the normal LS indications.

Testing Results: Not Passed

Negatives: Layering of the two indications on the ground needs to be looked into.

Conclusions: PR performed as expected, except the issue when spawning in.

Media: Screenshot 2025-02-14 214330

Thanks, I have added a fix which addresses the spawn in issue. Feel free to test it again if you'd like.

@Jaronics
Copy link

Quality Assurance Trainee Report

Discord Username : Jaronics
Object of testing : #9668
Aircraft : A380X
Tier of Testing : 1
Date : 26/02/2025

Testing Process:

  1. Loaded the plane up at the gate and observed the layering issue. It has disappeared
  2. Performed an ILS approach without the LS displayed. LS Flashed 9 times in amber.
  3. Tried the same with LOC only mode

Testing Results:
Passed

Negatives:
None

Conclusions:

Media:

@BravoMike99 BravoMike99 merged commit b95b8fc into flybywiresim:master Feb 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed QA Ready to Test QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants