Missed error handling

internal/api/handle_databases.go

@@ -70,7 +70,7 @@ func handleCreateDatabase(w http.ResponseWriter, r *http.Request) {
 		renderErr(w, err)
 		return
 	}
-	defer r.Body.Close()
+	defer func() { _ = r.Body.Close() }()
 
 	if err := admin.CreateDatabase(ctx, conn, input.Name); err != nil {
 		renderErr(w, err)

internal/api/handle_users.go

@@ -72,7 +72,7 @@ func handleCreateUser(w http.ResponseWriter, r *http.Request) {
 		renderErr(w, err)
 		return
 	}
-	defer r.Body.Close()
+	defer func() { _ = r.Body.Close() }()
 
 	err = admin.CreateUser(ctx, conn, input.Username, input.Password)
 	if err != nil {

internal/api/response.go

@@ -5,14 +5,18 @@ import (
 	"errors"
 	"net/http"
 
+	"log"
+
 	"github.com/jackc/pgconn"
 	"github.com/jackc/pgx/v5"
 )
 
 func renderJSON(w http.ResponseWriter, data interface{}, status int) {
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(status)
-	json.NewEncoder(w).Encode(data)
+	if err := json.NewEncoder(w).Encode(data); err != nil {
+		log.Printf("failed to write json response: %s", err)
+	}
 }
 
 func renderErr(w http.ResponseWriter, err error) {

internal/flycheck/checks.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"io"
+	"log"
 	"net/http"
 	"time"
 
@@ -96,10 +97,14 @@ func handleCheckResponse(w http.ResponseWriter, suite *check.CheckSuite, raw boo
 		handleError(w, errors.New(result))
 		return
 	}
-	io.WriteString(w, result)
+	if _, err := io.WriteString(w, result); err != nil {
+		log.Printf("failed to handle check response: %s", err)
+	}
 }
 
 func handleError(w http.ResponseWriter, err error) {
 	w.WriteHeader(http.StatusInternalServerError)
-	io.WriteString(w, err.Error())
+	if _, err := io.WriteString(w, err.Error()); err != nil {
+		log.Printf("failed to handle check error: %s", err)
+	}
 }

internal/flycheck/pg.go

@@ -37,8 +37,8 @@ func CheckPostgreSQL(ctx context.Context, checks *check.CheckSuite) (*check.Chec
 
 	// Cleanup connections
 	checks.OnCompletion = func() {
-		localConn.Close(ctx)
-		repConn.Close(ctx)
+		_ = localConn.Close(ctx)
+		_ = repConn.Close(ctx)
 	}
 
 	checks.AddCheck("connections", func() (string, error) {

internal/flycheck/role.go

@@ -23,7 +23,7 @@ func PostgreSQLRole(ctx context.Context, checks *check.CheckSuite) (*check.Check
 
 	// Cleanup connections
 	checks.OnCompletion = func() {
-		conn.Close(ctx)
+		_ = conn.Close(ctx)
 	}
 
 	checks.AddCheck("role", func() (string, error) {

internal/flycheck/vm.go

@@ -40,11 +40,14 @@ func checkPressure(name string) (string, error) {
 		return "", err
 	}
 
-	fmt.Sscanf(
+	_, err = fmt.Sscanf(
 		string(raw),
 		"some avg10=%f avg60=%f avg300=%f total=%f",
 		&avg10, &avg60, &avg300, &counter,
 	)
+	if err != nil {
+		return "", err
+	}
 
 	avg10Dur, err := pressureToDuration(avg10, 10.0)
 	if err != nil {

internal/flypg/config.go

@@ -144,7 +144,9 @@ func writeInternalConfigFile(c Config) error {
 
 	for key, value := range internal {
 		entry := fmt.Sprintf("%s = %v\n", key, value)
-		file.Write([]byte(entry))
+		if _, err := file.Write([]byte(entry)); err != nil {
+			return fmt.Errorf("failed to write to file: %s", err)
+		}
 	}
 
 	if err := file.Sync(); err != nil {
@@ -169,7 +171,9 @@ func writeUserConfigFile(c Config) error {
 
 	for key, value := range c.UserConfig() {
 		entry := fmt.Sprintf("%s = %v\n", key, value)
-		file.Write([]byte(entry))
+		if _, err := file.Write([]byte(entry)); err != nil {
+			return fmt.Errorf("failed to write to file: %s", err)
+		}
 	}
 
 	if err := file.Sync(); err != nil {

internal/flypg/readonly.go

@@ -14,8 +14,6 @@ import (
 
 const (
 	readOnlyLockFile = "/data/readonly.lock"
-	readOnlyEnabled  = "on"
-	readOnlyDisabled = "off"
 
 	ReadOnlyStateEndpoint    = "commands/admin/readonly/state"
 	BroadcastEnableEndpoint  = "commands/admin/readonly/enable"

internal/flypg/zombie.go

@@ -237,7 +237,10 @@ func handleZombieLock(ctx context.Context, n *Node) error {
 		}
 
 		// Ensure the single instance created with the --force-rewind process is cleaned up properly.
-		utils.RunCommand("pg_ctl -D /data/postgresql/ stop", "postgres")
+		_, err = utils.RunCommand("pg_ctl -D /data/postgresql/ stop", "postgres")
+		if err != nil {
+			return fmt.Errorf("failed to stop postgres: %s", err)
+		}
 	} else {
 		// TODO - Provide link to documention on how to address this
 		fmt.Println("Zombie lock file does not contain a hostname.")

internal/supervisor/output.go

@@ -63,8 +63,8 @@ func (m *multiOutput) PipeOutput(proc *process) {
 
 func (m *multiOutput) ClosePipe(proc *process) {
 	if pipe := m.pipes[proc]; pipe != nil {
-		pipe.pty.Close()
-		pipe.tty.Close()
+		_ = pipe.pty.Close()
+		_ = pipe.tty.Close()
 	}
 }