Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner: address regression in captured Helm logs #767

Merged
merged 2 commits into from
Sep 11, 2023
Merged

runner: address regression in captured Helm logs #767

merged 2 commits into from
Sep 11, 2023

Commits on Sep 11, 2023

  1. runner: address regression in captured Helm logs 

    This addresses a regression in the Helm log capturing introduced in
3b25041, which prevented valuable
information from the Kube client logs (e.g. the specific reason for a
timeout) to be added to the event emitted in case of a failure.

Signed-off-by: Hidde Beydals <[email protected]>
    @hiddeco
    hiddeco committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    eb3a4b8 View commit details
    Browse the repository at this point in the history

  2. controller: strip newlines from Helm error message 

    To prevent spurious newlines between the error message and the captured
logs, as at times Helm ends error with one or multiple newlines.

Signed-off-by: Hidde Beydals <[email protected]>
    @hiddeco
    hiddeco committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1aa7390 View commit details
    Browse the repository at this point in the history