Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request clean shutdown or helm operations as single pods / jobs #632

Closed
runningman84 opened this issue Mar 7, 2023 · 2 comments
Closed

Comments

@runningman84
Copy link

We have clusters in EKS where workers are controlled by karpenter. The worker nodes are spot instances. Therefore the cluster is quite dynamic nodes appear and disappear every few minutes.

Running helm controller on these nodes is risky because if you have long running helm install operations a given helm controller pod might be interrupted.

It would be great if the helm controller would wait before shutting down (which my still be an issue once a spot node is terminated within a 2 minute window) or would ensure that the given helm release does not stay in progress.

Another idea could be to use jobs or pods to do the single helm operation instead of doing everything in the main loop.

tldr I would like to run helm controller on short lives nodes without manual cleanups … right know I run it on fargate which is quite expensive compared to spot instances.

@hiddeco
Copy link
Member

hiddeco commented Mar 7, 2023

See #149 (comment). In combination with a sensitive retry configuration, this should ensure that from next release on releases should terminate gracefully (by marking them as "failed"), and then being retried once the controller finds a new node.

@hiddeco
Copy link
Member

hiddeco commented Mar 10, 2023

This should now happen in >=v0.31.0, see also #644.

@hiddeco hiddeco closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants