refactor: correctly compare string maps for drift state

Signed-off-by: Raffael Sahli <[email protected]>
fluxcd · Mar 16, 2023 · 9028e25 · 9028e25
1 parent ce24c09
commit 9028e25
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/controllers/helmrelease_controller_chart.go b/controllers/helmrelease_controller_chart.go
@@ -32,6 +32,7 @@ import (
 	"github.com/hashicorp/go-retryablehttp"
 	"helm.sh/helm/v3/pkg/chart"
 	"helm.sh/helm/v3/pkg/chart/loader"
+	apiequality "k8s.io/apimachinery/pkg/api/equality"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
@@ -245,9 +246,9 @@ func helmChartRequiresUpdate(hr *v2.HelmRelease, chart *sourcev1.HelmChart) bool
 		return true
 	case template.Spec.ValuesFile != chart.Spec.ValuesFile:
 		return true
-	case !reflect.DeepEqual(template.Annotations, chart.Annotations):
+	case !apiequality.Semantic.DeepEqual(template.Annotations, chart.Annotations):
 		return true
-	case !reflect.DeepEqual(template.Labels, chart.Labels):
+	case !apiequality.Semantic.DeepEqual(template.Labels, chart.Labels):
 		return true
 	case !reflect.DeepEqual(templateVerificationToSourceVerification(template.Spec.Verify), chart.Spec.Verify):
 		return true