Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all project controllers private #3719

Closed
5 of 6 tasks
aryan9600 opened this issue Mar 23, 2023 · 1 comment · Fixed by fluxcd/source-controller#1076
Closed
5 of 6 tasks

Make all project controllers private #3719

aryan9600 opened this issue Mar 23, 2023 · 1 comment · Fixed by fluxcd/source-controller#1076
Labels
umbrella-issue Umbrella issue for tracking progress of a larger effort

Comments

@aryan9600
Copy link
Member

aryan9600 commented Mar 23, 2023 •
edited by makkes
Loading

Kubebuilder v4 is changing its project directory to have controllers in the internal dir (ref: https://github.com/kubernetes-sigs/kubebuilder/tree/7f5d552d315413cbc4d18cf812e173c4f8311d2c/docs/book/src/cronjob-tutorial/testdata/project/internal/controller). We should adopt this change for all our controllers:

  • fluxcd/source-controller
  • fluxcd/helm-controller
  • fluxcd/kustomize-controller
  • fluxcd/notification-controller
  • fluxcd/image-reflector-controller
  • fluxcd/image-automation-controller
@aryan9600 aryan9600 added the umbrella-issue Umbrella issue for tracking progress of a larger effort label Mar 23, 2023
This was referenced Mar 27, 2023
Merged
Merged
This was referenced Mar 27, 2023
Merged
Merged
This was referenced Mar 29, 2023
Merged
Closed
@darkowlzz darkowlzz mentioned this issue Apr 17, 2023
Merged
@makkes makkes reopened this Apr 18, 2023
@makkes
Copy link
Member

makkes commented Apr 18, 2023

re-opening as SC hasn't been tackled, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
umbrella-issue Umbrella issue for tracking progress of a larger effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move controllers to internal/controller fluxcd/source-controller
3 participants
@makkes @stefanprodan @aryan9600