Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android_intent_plus): adds getResolvedActivity method #3313

Conversation

josh-burton
Copy link
Contributor

Description

Adds getResolvedActivity to return app name, activity name and package name of the default activity that will be resolved for a given intent.

Related Issues

Checklist

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It's a nice to have feature and I think we will have no issue adding it.

I added some comments to the PR, I'd also like to ask you to add the following:

  • Add the new functionality to the README.md of the package. (e.g. short explanation and usage example)
  • Add an integration test in example/integration_test/android_intent_plus_test.dart

@josh-burton josh-burton force-pushed the android-intents-resolved-activity branch from 0f97238 to 312240d Compare October 10, 2024 07:15
@josh-burton
Copy link
Contributor Author

Thanks for the comments :) I've addressed them all except the integration test. This might take me a bit longer as there wasn't an integration test for canResolveActivity.

@josh-burton
Copy link
Contributor Author

@miquelbeltran are the integration tests (Robolectric tests) maintained/used?

I can see android_test.sh in the android_intent_plus folder, but running it fails for me, and I can't see where this is run on CI.

@josh-burton josh-burton force-pushed the android-intents-resolved-activity branch from 312240d to 2bb3586 Compare October 10, 2024 07:29
@josh-burton
Copy link
Contributor Author

@miquelbeltran are the integration tests (Robolectric tests) maintained/used?

I can see android_test.sh in the android_intent_plus folder, but running it fails for me, and I can't see where this is run on CI.

Sorry I was looking at the wrong tests. I've added integration tests now and I believe all the comments are addressed.

It does look like the roboelectric tests are not used so perhaps these should be removed.

@miquelbeltran
Copy link
Member

Thanks for the changes! Self-assigning, I want to test on my device before merging.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miquelbeltran miquelbeltran merged commit 8ad1c6d into fluttercommunity:main Oct 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants