-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android_intent_plus): adds getResolvedActivity method #3313
feat(android_intent_plus): adds getResolvedActivity method #3313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! It's a nice to have feature and I think we will have no issue adding it.
I added some comments to the PR, I'd also like to ask you to add the following:
- Add the new functionality to the README.md of the package. (e.g. short explanation and usage example)
- Add an integration test in
example/integration_test/android_intent_plus_test.dart
packages/android_intent_plus/example/android/app/src/main/AndroidManifest.xml
Show resolved
Hide resolved
packages/android_intent_plus/example/android/app/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
0f97238
to
312240d
Compare
Thanks for the comments :) I've addressed them all except the integration test. This might take me a bit longer as there wasn't an integration test for canResolveActivity. |
@miquelbeltran are the integration tests (Robolectric tests) maintained/used? I can see |
…default resolved activity details
312240d
to
2bb3586
Compare
Sorry I was looking at the wrong tests. I've added integration tests now and I believe all the comments are addressed. It does look like the roboelectric tests are not used so perhaps these should be removed. |
Thanks for the changes! Self-assigning, I want to test on my device before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds getResolvedActivity to return app name, activity name and package name of the default activity that will be resolved for a given intent.
Related Issues
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).