Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As shown in the screenshot,The H5 video element's full screen control button is not available. #423

Open
lyzcw opened this issue May 21, 2019 · 15 comments

Comments

@lyzcw
Copy link

lyzcw commented May 21, 2019

As the title,As shown in the screenshot.
NoFullsreen

@lyzcw
Copy link
Author

lyzcw commented May 21, 2019

As we all know, it's a bad experience to play video on the mobile without fullscreen.

@lyzcw lyzcw changed the title Why did the H5 video element full screen control button not respond? As shown in the screenshot,The H5 video element's full screen control button is not available. May 22, 2019
@lyzcw
Copy link
Author

lyzcw commented May 23, 2019

@slightfoot @charafau Please pay attention to this Issue.

@slightfoot
Copy link
Member

Thanks for bringing this up. I think full-screen video playback already works on iOS. This needs confirmation. I am just dropping some reference docs here for later Android implantation.

https://developer.android.com/reference/android/webkit/WebChromeClient#onShowCustomView(android.view.View,%2520android.webkit.WebChromeClient.CustomViewCallback)
https://developer.android.com/training/system-ui/immersive
https://github.com/cprcrack/VideoEnabledWebView < code not up to stratch but helps understand implentation.

Basically we override onShowCustomView and onHideCustomView to display a Custom-View in-place of the Web-View. We can also choose to enable the immersive mode on Android to hide the system chrome like status. We also want to override the back button behaviour such that if the custom-view is open it will close it on first tap of back button.

Further research required.

@lyzcw
Copy link
Author

lyzcw commented May 23, 2019

@slightfoot Great. Thank you very much for your response in the middle of the night. Looking forward to the new version.

@lyzcw
Copy link
Author

lyzcw commented Jul 11, 2019

Thanks for bringing this up. I think full-screen video playback already works on iOS. This needs confirmation. I am just dropping some reference docs here for later Android implantation.

https://developer.android.com/reference/android/webkit/WebChromeClient#onShowCustomView(android.view.View,%2520android.webkit.WebChromeClient.CustomViewCallback)
https://developer.android.com/training/system-ui/immersive
https://github.com/cprcrack/VideoEnabledWebView < code not up to stratch but helps understand implentation.

Basically we override onShowCustomView and onHideCustomView to display a Custom-View in-place of the Web-View. We can also choose to enable the immersive mode on Android to hide the system chrome like status. We also want to override the back button behaviour such that if the custom-view is open it will close it on first tap of back button.

Further research required.

@slightfoot On Android platform, has this problem been solved?

@lyzcw
Copy link
Author

lyzcw commented Jul 12, 2019

@charafau

@TEENSTITANS
Copy link

Looking forward to solving the problem!

@mschneider
Copy link
Contributor

@slightfoot do you see any issues with this solution?

@lyzcw
Copy link
Author

lyzcw commented Nov 13, 2019

@slightfoot @charafau Looking forward to the solution of this problem.

@lyzcw
Copy link
Author

lyzcw commented Dec 19, 2019

Looking forward to ....

@lyzcw
Copy link
Author

lyzcw commented Feb 14, 2020

@slightfoot @charafau Looking forward to the solution of this problem.

1 similar comment
@lyzcw
Copy link
Author

lyzcw commented Feb 19, 2020

@slightfoot @charafau Looking forward to the solution of this problem.

@jerry90
Copy link

jerry90 commented Apr 24, 2020

Looking forward to ....

@YaseenAbdullah
Copy link

Looking forward to..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants