Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't handle exceptions #41

Closed
Holofox opened this issue Jun 18, 2021 · 1 comment
Closed

[Bug] Can't handle exceptions #41

Holofox opened this issue Jun 18, 2021 · 1 comment
Labels
s: enhancement This issue addressed some enhancement. ⏳WEEK This issue is scheduled to be solved within one week.

Comments

@Holofox
Copy link

Holofox commented Jun 18, 2021

The package suppresses all exceptions that may occur while working with the camera. This is not correct because it is not possible to handle the denial of permission to access the camera and any other exception that is thrown.

Take a look at the following pieces of code:

} on CameraException catch (e) {
realDebugPrint('CameraException: $e');
} finally {

} catch (e) {
realDebugPrint('Error when switch flash mode: $e');
}

I gave as an example, in fact, there are more such places.

@Holofox Holofox changed the title Can't handle exceptions [Bug] Can't handle exceptions Jun 18, 2021
@AlexV525 AlexV525 added s: enhancement This issue addressed some enhancement. ⏳WEEK This issue is scheduled to be solved within one week. labels Jun 18, 2021
@AlexV525
Copy link
Member

Thanks for the feedback. If you're able to submit a PR for this, I'll be happy to help you land an enhancement, since I'm quite busy in some other works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: enhancement This issue addressed some enhancement. ⏳WEEK This issue is scheduled to be solved within one week.
Projects
None yet
Development

No branches or pull requests

2 participants