[webview_flutter] iOS now can open iframe links and target _blank links - #2067
[webview_flutter] iOS now can open iframe links and target _blank links#2067rodruiz wants to merge 15 commits into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Hi, |
|
@googlebot I fixed it. |
|
Hi @amirh, could you review this PR? |
|
Hi @amirh, any plans to review this PR? |
|
Hi @amirh, could you review this PR please? |
|
Hi @amirh, could you review this PR please? |
amirh
left a comment
There was a problem hiding this comment.
Thanks!
We'd need to test opening a _blank link before this can land, I we can add an e2e test case to cover it here: https://github.com/flutter/plugins/blob/master/packages/webview_flutter/example/test_driver/webview_flutter_e2e.dart
| webView.getSettings().setDomStorageEnabled(true); | ||
|
|
||
| // Allow zoom and hide the zoom in and zoom out buttons. | ||
| webView.getSettings().setSupportZoom(true); |
There was a problem hiding this comment.
Should this setting be controllable by the app developer? any I'd suggest splitting these 2 features to separate PRs
| name: webview_flutter | ||
| description: A Flutter plugin that provides a WebView widget on Android and iOS. | ||
| version: 0.3.19+5 | ||
| version: 0.3.19+6 |
There was a problem hiding this comment.
I wonder whether we should consider this a breaking change (as it will break any app relying on these links not being opened)
|
Closing in favor of #2500 |
Description
iOS will be able to open iframe links, ads and target _blank links.
Related Issues
Fix issue 28875.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?