From 0e06aeeeb220b557e416d2b641c0ea8cb491237b Mon Sep 17 00:00:00 2001 From: Yaakov Schectman Date: Wed, 11 Sep 2024 12:40:31 -0400 Subject: [PATCH 1/2] Fix typo --- .../google_maps_flutter_platform_interface/CHANGELOG.md | 4 ++++ .../lib/src/types/camera.dart | 2 +- .../google_maps_flutter_platform_interface/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md b/packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md index b1960ba3504..e39c3d5a501 100644 --- a/packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md +++ b/packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.9.2 + +* Corrects JSON tag for `CameraUpdateNewLatLngBounds`. + ## 2.9.1 * Splits CameraUpdate into dervied classes for different update cases. diff --git a/packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/camera.dart b/packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/camera.dart index d0ee5af1153..a251d2bba8d 100644 --- a/packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/camera.dart +++ b/packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/camera.dart @@ -251,7 +251,7 @@ class CameraUpdateNewLatLngBounds extends CameraUpdate { /// The amount of padding by which the view is inset. final double padding; @override - Object toJson() => ['newLatLngZoom', bounds.toJson(), padding]; + Object toJson() => ['newLatLngBounds', bounds.toJson(), padding]; } /// Defines a camera move to new coordinates with a zoom level. diff --git a/packages/google_maps_flutter/google_maps_flutter_platform_interface/pubspec.yaml b/packages/google_maps_flutter/google_maps_flutter_platform_interface/pubspec.yaml index 805164c520d..4a4489320fd 100644 --- a/packages/google_maps_flutter/google_maps_flutter_platform_interface/pubspec.yaml +++ b/packages/google_maps_flutter/google_maps_flutter_platform_interface/pubspec.yaml @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/google_maps_f issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 2.9.1 +version: 2.9.2 environment: sdk: ^3.3.0 From 15796b54bfd2afbcac21586e196b1cb081180489 Mon Sep 17 00:00:00 2001 From: Yaakov Schectman Date: Wed, 11 Sep 2024 12:54:59 -0400 Subject: [PATCH 2/2] Test JSON tags --- .../test/types/camera_test.dart | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/camera_test.dart b/packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/camera_test.dart index 43ee478127b..4c4214b2609 100644 --- a/packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/camera_test.dart +++ b/packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/camera_test.dart @@ -30,6 +30,8 @@ void main() { expect(cameraUpdate.updateType, CameraUpdateType.newCameraPosition); cameraUpdate as CameraUpdateNewCameraPosition; expect(cameraUpdate.cameraPosition, cameraPosition); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'newCameraPosition'); }); test('CameraUpdate.newLatLng', () { @@ -39,6 +41,8 @@ void main() { expect(cameraUpdate.updateType, CameraUpdateType.newLatLng); cameraUpdate as CameraUpdateNewLatLng; expect(cameraUpdate.latLng, latLng); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'newLatLng'); }); test('CameraUpdate.newLatLngBounds', () { @@ -52,6 +56,8 @@ void main() { cameraUpdate as CameraUpdateNewLatLngBounds; expect(cameraUpdate.bounds, latLngBounds); expect(cameraUpdate.padding, padding); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'newLatLngBounds'); }); test('CameraUpdate.newLatLngZoom', () { @@ -63,6 +69,8 @@ void main() { cameraUpdate as CameraUpdateNewLatLngZoom; expect(cameraUpdate.latLng, latLng); expect(cameraUpdate.zoom, zoom); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'newLatLngZoom'); }); test('CameraUpdate.scrollBy', () { @@ -74,6 +82,8 @@ void main() { cameraUpdate as CameraUpdateScrollBy; expect(cameraUpdate.dx, dx); expect(cameraUpdate.dy, dy); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'scrollBy'); }); test('CameraUpdate.zoomBy', () { @@ -85,17 +95,23 @@ void main() { cameraUpdate as CameraUpdateZoomBy; expect(cameraUpdate.amount, amount); expect(cameraUpdate.focus, focus); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'zoomBy'); }); test('CameraUpdate.zoomIn', () { final CameraUpdate cameraUpdate = CameraUpdate.zoomIn(); expect(cameraUpdate.runtimeType, CameraUpdateZoomIn); expect(cameraUpdate.updateType, CameraUpdateType.zoomIn); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'zoomIn'); }); test('CameraUpdate.zoomOut', () { final CameraUpdate cameraUpdate = CameraUpdate.zoomOut(); expect(cameraUpdate.runtimeType, CameraUpdateZoomOut); expect(cameraUpdate.updateType, CameraUpdateType.zoomOut); + final List jsonList = cameraUpdate.toJson() as List; + expect(jsonList[0], 'zoomOut'); }); }