From 6a2553f913737f95f64b6b7b0687cb74a125f1c1 Mon Sep 17 00:00:00 2001 From: Victoria Ashworth Date: Thu, 16 May 2024 10:11:00 -0500 Subject: [PATCH 1/4] Skip 'Video playback policy Auto media playback' drive test --- .../example/integration_test/webview_flutter_test.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart index de5d3df6dea..9dbf25b5437 100644 --- a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart @@ -302,7 +302,9 @@ Future main() async { isPaused = await controller.runJavaScriptReturningResult('isPaused();') as bool; expect(isPaused, true); - }); + }, + // TODO: Stop skipping once https://github.com/flutter/flutter/issues/148487 is resolved + skip: true); testWidgets('Video plays inline', (WidgetTester tester) async { final Completer pageLoaded = Completer(); From a4ee0599d6b63bea7b6014909b1d0c6db1818702 Mon Sep 17 00:00:00 2001 From: Victoria Ashworth Date: Thu, 16 May 2024 10:42:24 -0500 Subject: [PATCH 2/4] Retrigger tests From cc9e32bafdec3bbcb01587f4c8291e598bb48cb3 Mon Sep 17 00:00:00 2001 From: Victoria Ashworth Date: Thu, 16 May 2024 11:06:43 -0500 Subject: [PATCH 3/4] assign TODO --- .../example/integration_test/webview_flutter_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart index 9dbf25b5437..5b8e9fea0ad 100644 --- a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart @@ -303,7 +303,7 @@ Future main() async { await controller.runJavaScriptReturningResult('isPaused();') as bool; expect(isPaused, true); }, - // TODO: Stop skipping once https://github.com/flutter/flutter/issues/148487 is resolved + // TODO(bparrishMines): Stop skipping once https://github.com/flutter/flutter/issues/148487 is resolved skip: true); testWidgets('Video plays inline', (WidgetTester tester) async { From fc0129ec807c49dafb26b6082712d04d23b53cf7 Mon Sep 17 00:00:00 2001 From: Victoria Ashworth Date: Thu, 16 May 2024 11:53:12 -0500 Subject: [PATCH 4/4] Skip all Video playback policy tests --- .../example/integration_test/webview_flutter_test.dart | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart index 5b8e9fea0ad..51f1cd872d8 100644 --- a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart @@ -302,9 +302,7 @@ Future main() async { isPaused = await controller.runJavaScriptReturningResult('isPaused();') as bool; expect(isPaused, true); - }, - // TODO(bparrishMines): Stop skipping once https://github.com/flutter/flutter/issues/148487 is resolved - skip: true); + }); testWidgets('Video plays inline', (WidgetTester tester) async { final Completer pageLoaded = Completer(); @@ -359,7 +357,9 @@ Future main() async { .runJavaScriptReturningResult('isFullScreen();') as bool; expect(fullScreen, false); }); - }); + }, + // TODO(bparrishMines): Stop skipping once https://github.com/flutter/flutter/issues/148487 is resolved + skip: true); group('Audio playback policy', () { late String audioTestBase64;