From 9d3c850c7cf111e7f50cbf7a2a85e0d89253edb7 Mon Sep 17 00:00:00 2001
From: Timm Preetz <timm@preetz.us>
Date: Mon, 5 Feb 2024 13:58:32 +0100
Subject: [PATCH] [video_player] Call `super.dispose` last in README example

As per https://api.flutter.dev/flutter/widgets/State/dispose.html

> Implementations of this method should end with a call to the inherited method, as in super.dispose().
---
 packages/video_player/video_player/CHANGELOG.md           | 4 ++++
 packages/video_player/video_player/README.md              | 2 +-
 packages/video_player/video_player/example/lib/basic.dart | 2 +-
 packages/video_player/video_player/pubspec.yaml           | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/video_player/video_player/CHANGELOG.md b/packages/video_player/video_player/CHANGELOG.md
index 595b483ae123..711e1defd4c9 100644
--- a/packages/video_player/video_player/CHANGELOG.md
+++ b/packages/video_player/video_player/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.8.5
+
+* Updates example to call `super.dispose()` last.
+
 ## 2.8.4
 
 * Removes `_ambiguate` methods from code.
diff --git a/packages/video_player/video_player/README.md b/packages/video_player/video_player/README.md
index 4d39cec336e7..55f4d2f614b3 100644
--- a/packages/video_player/video_player/README.md
+++ b/packages/video_player/video_player/README.md
@@ -118,8 +118,8 @@ class _VideoAppState extends State<VideoApp> {
 
   @override
   void dispose() {
-    super.dispose();
     _controller.dispose();
+    super.dispose();
   }
 }
 ```
diff --git a/packages/video_player/video_player/example/lib/basic.dart b/packages/video_player/video_player/example/lib/basic.dart
index af42187889d3..c2c92047f9ef 100644
--- a/packages/video_player/video_player/example/lib/basic.dart
+++ b/packages/video_player/video_player/example/lib/basic.dart
@@ -66,8 +66,8 @@ class _VideoAppState extends State<VideoApp> {
 
   @override
   void dispose() {
-    super.dispose();
     _controller.dispose();
+    super.dispose();
   }
 }
 // #enddocregion basic-example
diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml
index 757e89f84fea..0dcd807192ca 100644
--- a/packages/video_player/video_player/pubspec.yaml
+++ b/packages/video_player/video_player/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for displaying inline video with other Flutter
   widgets on Android, iOS, and web.
 repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
-version: 2.8.4
+version: 2.8.5
 
 environment:
   sdk: ">=3.1.0 <4.0.0"