From 9273bf31724b2aad6c1a943b1b5f2e31ce23a80c Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Sun, 5 Nov 2023 12:02:24 +0530 Subject: [PATCH 01/12] [cupertino_icons] Add example to cupertino icons --- third_party/packages/cupertino_icons/example/example.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 third_party/packages/cupertino_icons/example/example.md diff --git a/third_party/packages/cupertino_icons/example/example.md b/third_party/packages/cupertino_icons/example/example.md new file mode 100644 index 00000000000..271e5031b64 --- /dev/null +++ b/third_party/packages/cupertino_icons/example/example.md @@ -0,0 +1,3 @@ +Please find the usage of `cupertino_icons` here + +https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html From 997cd0c9843d50e6b08a100a0e43b8e26a082592 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Mon, 6 Nov 2023 11:04:43 +0530 Subject: [PATCH 02/12] [cupertino_icons] Update package version --- third_party/packages/cupertino_icons/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/packages/cupertino_icons/pubspec.yaml b/third_party/packages/cupertino_icons/pubspec.yaml index 1e0b09766d7..302f971f083 100644 --- a/third_party/packages/cupertino_icons/pubspec.yaml +++ b/third_party/packages/cupertino_icons/pubspec.yaml @@ -3,7 +3,7 @@ name: cupertino_icons description: Default icons asset for Cupertino widgets based on Apple styled icons repository: https://github.com/flutter/packages/tree/main/third_party/packages/cupertino_icons issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+cupertino_icons%22 -version: 1.0.6 +version: 1.0.7 environment: sdk: ">=3.0.0 <4.0.0" From 77d5b04ddec04e531075a470a7028efc78dd8b70 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Mon, 6 Nov 2023 11:05:02 +0530 Subject: [PATCH 03/12] [cupertino_icons] Update CHANGELOG.md --- third_party/packages/cupertino_icons/CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/third_party/packages/cupertino_icons/CHANGELOG.md b/third_party/packages/cupertino_icons/CHANGELOG.md index b069e04f97d..f8d483539db 100644 --- a/third_party/packages/cupertino_icons/CHANGELOG.md +++ b/third_party/packages/cupertino_icons/CHANGELOG.md @@ -1,5 +1,6 @@ -## NEXT +## 1.0.7 +* Adds example.md file to display usage of `cupertino_icons` * Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. ## 1.0.6 From 221ec3a35e59f898206604a77678ee0cf20f2de4 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Mon, 6 Nov 2023 19:12:21 +0530 Subject: [PATCH 04/12] [cupertino_icons] Add an simple example widget and documentation link --- third_party/packages/cupertino_icons/CHANGELOG.md | 2 +- .../packages/cupertino_icons/example/example.md | 13 +++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/third_party/packages/cupertino_icons/CHANGELOG.md b/third_party/packages/cupertino_icons/CHANGELOG.md index f8d483539db..03d6590c829 100644 --- a/third_party/packages/cupertino_icons/CHANGELOG.md +++ b/third_party/packages/cupertino_icons/CHANGELOG.md @@ -1,6 +1,6 @@ ## 1.0.7 -* Adds example.md file to display usage of `cupertino_icons` +* Adds example.md file to display usage of `cupertino_icons`. * Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. ## 1.0.6 diff --git a/third_party/packages/cupertino_icons/example/example.md b/third_party/packages/cupertino_icons/example/example.md index 271e5031b64..d765b0bb51c 100644 --- a/third_party/packages/cupertino_icons/example/example.md +++ b/third_party/packages/cupertino_icons/example/example.md @@ -1,3 +1,12 @@ -Please find the usage of `cupertino_icons` here +Please find the usage of [`cupertino_icons`](https://pub.dev/packages/cupertino_icons) which is used via Flutter's `CupertinoIcons` class below: -https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html +```dart +Icon( + CupertinoIcons.heart_fill, + color: Colors.pink, + size: 24.0, + semanticLabel: 'Text to announce in accessibility modes', +) +``` + +For a list of all icons, see [`CupertinoIcons`](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html#constants) [class documentation constants](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html#constants). From 249a9d9bd0da761b669120344cd6dafa4373a762 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Sat, 2 Dec 2023 10:12:38 +0530 Subject: [PATCH 05/12] [cupertino_icons] Use code excerpts in example.md file for linted and compiled code --- .../cupertino_icons/example/example.md | 15 ++++++---- .../packages/cupertino_icons/pubspec.yaml | 8 +++++ .../test/cupertino_icons_test.dart | 29 +++++++++++++++++++ 3 files changed, 46 insertions(+), 6 deletions(-) create mode 100644 third_party/packages/cupertino_icons/test/cupertino_icons_test.dart diff --git a/third_party/packages/cupertino_icons/example/example.md b/third_party/packages/cupertino_icons/example/example.md index d765b0bb51c..4bbb336a40c 100644 --- a/third_party/packages/cupertino_icons/example/example.md +++ b/third_party/packages/cupertino_icons/example/example.md @@ -1,12 +1,15 @@ + + Please find the usage of [`cupertino_icons`](https://pub.dev/packages/cupertino_icons) which is used via Flutter's `CupertinoIcons` class below: + ```dart -Icon( - CupertinoIcons.heart_fill, - color: Colors.pink, - size: 24.0, - semanticLabel: 'Text to announce in accessibility modes', -) +const Icon icon = Icon( + CupertinoIcons.heart_fill, + color: Colors.pink, + size: 24.0, + semanticLabel: 'Text to announce in accessibility modes', +); ``` For a list of all icons, see [`CupertinoIcons`](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html#constants) [class documentation constants](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html#constants). diff --git a/third_party/packages/cupertino_icons/pubspec.yaml b/third_party/packages/cupertino_icons/pubspec.yaml index 302f971f083..3e07de48572 100644 --- a/third_party/packages/cupertino_icons/pubspec.yaml +++ b/third_party/packages/cupertino_icons/pubspec.yaml @@ -14,6 +14,14 @@ flutter: fonts: - asset: assets/CupertinoIcons.ttf +dependencies: + flutter: + sdk: flutter + +dev_dependencies: + flutter_test: + sdk: flutter + topics: - assets - icons diff --git a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart new file mode 100644 index 00000000000..6e02b243b5b --- /dev/null +++ b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart @@ -0,0 +1,29 @@ +import 'package:flutter/cupertino.dart'; +import 'package:flutter/material.dart'; +import 'package:flutter_test/flutter_test.dart'; + +void main() { + testWidgets( + 'Cupertino Icon Test', + (WidgetTester tester) async { + // #docregion CupertinoIcon + const Icon icon = Icon( + CupertinoIcons.heart_fill, + color: Colors.pink, + size: 24.0, + semanticLabel: 'Text to announce in accessibility modes', + ); + // #enddocregion CupertinoIcon + + await tester.pumpWidget( + const MaterialApp( + home: Scaffold( + body: icon, + ), + ), + ); + + expect(find.byType(Icon), findsOne); + }, + ); +} From 42c2ff566b0d45ab856c5416582c454aac5652c0 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Sat, 2 Dec 2023 10:45:33 +0530 Subject: [PATCH 06/12] [cupertino_icons] Follow standard repository ordering. Major sections should follow standard repository ordering: environment: dependencies: dev_dependencies: flutter: topics: screenshots: false_secrets: --- third_party/packages/cupertino_icons/pubspec.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/third_party/packages/cupertino_icons/pubspec.yaml b/third_party/packages/cupertino_icons/pubspec.yaml index 3e07de48572..6cc4c3ca461 100644 --- a/third_party/packages/cupertino_icons/pubspec.yaml +++ b/third_party/packages/cupertino_icons/pubspec.yaml @@ -8,12 +8,6 @@ version: 1.0.7 environment: sdk: ">=3.0.0 <4.0.0" -flutter: - fonts: - - family: CupertinoIcons - fonts: - - asset: assets/CupertinoIcons.ttf - dependencies: flutter: sdk: flutter @@ -22,6 +16,12 @@ dev_dependencies: flutter_test: sdk: flutter +flutter: + fonts: + - family: CupertinoIcons + fonts: + - asset: assets/CupertinoIcons.ttf + topics: - assets - icons From f0503d0f814385c4dcc78cae1c38408b3f80bb70 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Sat, 2 Dec 2023 10:46:38 +0530 Subject: [PATCH 07/12] [cupertino_icons] Add license in test file --- .../packages/cupertino_icons/test/cupertino_icons_test.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart index 6e02b243b5b..638ad129534 100644 --- a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart +++ b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart @@ -1,3 +1,7 @@ +// Copyright 2013 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; From 0498d9bc2b08ebd697a6ac614bd73bac5b28e1fa Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Mon, 25 Dec 2023 09:47:57 +0530 Subject: [PATCH 08/12] [cupertino_icons] Update CHANGELOG --- third_party/packages/cupertino_icons/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/packages/cupertino_icons/CHANGELOG.md b/third_party/packages/cupertino_icons/CHANGELOG.md index 03d6590c829..636e9af1b79 100644 --- a/third_party/packages/cupertino_icons/CHANGELOG.md +++ b/third_party/packages/cupertino_icons/CHANGELOG.md @@ -1,6 +1,6 @@ ## 1.0.7 -* Adds example.md file to display usage of `cupertino_icons`. +* Adds example.md file to display usage. * Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. ## 1.0.6 From f8224610e9994ac9e16dbceee4ccbb812f8708ed Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Mon, 25 Dec 2023 09:49:34 +0530 Subject: [PATCH 09/12] [cupertino_icons] Add flutter as a dev dependency --- third_party/packages/cupertino_icons/pubspec.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/third_party/packages/cupertino_icons/pubspec.yaml b/third_party/packages/cupertino_icons/pubspec.yaml index 6cc4c3ca461..322124cf4e7 100644 --- a/third_party/packages/cupertino_icons/pubspec.yaml +++ b/third_party/packages/cupertino_icons/pubspec.yaml @@ -8,11 +8,9 @@ version: 1.0.7 environment: sdk: ">=3.0.0 <4.0.0" -dependencies: +dev_dependencies: flutter: sdk: flutter - -dev_dependencies: flutter_test: sdk: flutter From 7c2cf488092c964b12c0954834625cdb8975a700 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Mon, 25 Dec 2023 09:50:24 +0530 Subject: [PATCH 10/12] [cupertino_icons] Update code excerpts and add doc-level comment in test file --- third_party/packages/cupertino_icons/example/example.md | 3 +-- .../packages/cupertino_icons/test/cupertino_icons_test.dart | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/third_party/packages/cupertino_icons/example/example.md b/third_party/packages/cupertino_icons/example/example.md index 4bbb336a40c..1b6bc0ac27b 100644 --- a/third_party/packages/cupertino_icons/example/example.md +++ b/third_party/packages/cupertino_icons/example/example.md @@ -1,6 +1,6 @@ -Please find the usage of [`cupertino_icons`](https://pub.dev/packages/cupertino_icons) which is used via Flutter's `CupertinoIcons` class below: +This package is used via [`CupertinoIcons`](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html): ```dart @@ -8,7 +8,6 @@ const Icon icon = Icon( CupertinoIcons.heart_fill, color: Colors.pink, size: 24.0, - semanticLabel: 'Text to announce in accessibility modes', ); ``` diff --git a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart index 638ad129534..dd0eb0772dc 100644 --- a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart +++ b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart @@ -1,6 +1,7 @@ // Copyright 2013 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +/// This test file is primarily here to serve as a source for code excerpts. import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; @@ -15,7 +16,6 @@ void main() { CupertinoIcons.heart_fill, color: Colors.pink, size: 24.0, - semanticLabel: 'Text to announce in accessibility modes', ); // #enddocregion CupertinoIcon From 3f24c60834d65b18b82311cf3bc751b12be9b6a9 Mon Sep 17 00:00:00 2001 From: Ravi Lodhi Date: Sun, 28 Jan 2024 15:12:39 +0530 Subject: [PATCH 11/12] [cupertino_icons] Adds a 'library' directive after the library comment --- .../packages/cupertino_icons/test/cupertino_icons_test.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart index dd0eb0772dc..2b2ab8ce2a7 100644 --- a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart +++ b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. /// This test file is primarily here to serve as a source for code excerpts. +library; import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; From da1afdaef82276690f42144b437072f80218e140 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Mon, 12 Feb 2024 14:28:42 -0500 Subject: [PATCH 12/12] Add blank line --- .../packages/cupertino_icons/test/cupertino_icons_test.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart index 2b2ab8ce2a7..bb61b92c509 100644 --- a/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart +++ b/third_party/packages/cupertino_icons/test/cupertino_icons_test.dart @@ -1,6 +1,7 @@ // Copyright 2013 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. + /// This test file is primarily here to serve as a source for code excerpts. library;