From bd8505b8037f0edef7bb242eddec3682086cfa9b Mon Sep 17 00:00:00 2001 From: Delwin Mathew Date: Thu, 17 Aug 2023 14:42:20 +0530 Subject: [PATCH 1/6] documentation update fixes issue flutter/flutter#132727 --- .../webview_flutter/lib/src/webview_controller.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart b/packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart index f8e4c411a8e..13435edd6fe 100644 --- a/packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart +++ b/packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart @@ -266,8 +266,8 @@ class WebViewController { /// ```dart /// final WebViewController controller = WebViewController(); /// controller.addJavaScriptChannel( - /// name: 'Print', - /// onMessageReceived: (JavascriptMessage message) { + /// 'Print', + /// onMessageReceived: (JavaScriptMessage message) { /// print(message.message); /// }, /// ); From e15ae7005ab550024ca577d511a74265a92f88b4 Mon Sep 17 00:00:00 2001 From: Delwin Mathew Date: Thu, 17 Aug 2023 14:55:05 +0530 Subject: [PATCH 2/6] version and `changelog.md` update --- packages/webview_flutter/webview_flutter/CHANGELOG.md | 4 ++++ packages/webview_flutter/webview_flutter/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/CHANGELOG.md b/packages/webview_flutter/webview_flutter/CHANGELOG.md index 0b2e4dfa9b2..74d0418d3de 100644 --- a/packages/webview_flutter/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 4.2.3 + +* Updates code sample. + ## 4.2.2 * Fixes documentation typo. diff --git a/packages/webview_flutter/webview_flutter/pubspec.yaml b/packages/webview_flutter/webview_flutter/pubspec.yaml index 6dae99f307c..c23d186140b 100644 --- a/packages/webview_flutter/webview_flutter/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter description: A Flutter plugin that provides a WebView widget on Android and iOS. repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 4.2.2 +version: 4.2.3 environment: sdk: ">=2.18.0 <4.0.0" From a513f2aa4dead4cfa0b38d9f0b54258aa4ff0142 Mon Sep 17 00:00:00 2001 From: Delwin Mathew <84124091+opxdelwin@users.noreply.github.com> Date: Sat, 19 Aug 2023 09:30:51 +0530 Subject: [PATCH 3/6] Implement suggested changes in `CHANGELOG.md` Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> --- packages/webview_flutter/webview_flutter/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/CHANGELOG.md b/packages/webview_flutter/webview_flutter/CHANGELOG.md index 74d0418d3de..e46bfea8ec2 100644 --- a/packages/webview_flutter/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter/CHANGELOG.md @@ -1,6 +1,6 @@ ## 4.2.3 -* Updates code sample. +* Fixes the code sample in the dartdocs for `WebViewController.addJavaScriptChannel`. ## 4.2.2 From 98f8131c07bc0a2868a90211dd41f6797e688a56 Mon Sep 17 00:00:00 2001 From: Delwin Mathew Date: Sun, 20 Aug 2023 22:20:03 +0530 Subject: [PATCH 4/6] CHANGELOG update 4.2.3 --- packages/webview_flutter/webview_flutter/CHANGELOG.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/webview_flutter/webview_flutter/CHANGELOG.md b/packages/webview_flutter/webview_flutter/CHANGELOG.md index 27a281b25a2..e46bfea8ec2 100644 --- a/packages/webview_flutter/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter/CHANGELOG.md @@ -1,7 +1,3 @@ -## NEXT - -* Updates minimum supported SDK version to Flutter 3.7/Dart 2.19. - ## 4.2.3 * Fixes the code sample in the dartdocs for `WebViewController.addJavaScriptChannel`. From 2ef5bdd366d9017c8cf675b0142c30f5817679ba Mon Sep 17 00:00:00 2001 From: Delwin Mathew Date: Mon, 21 Aug 2023 19:10:51 +0530 Subject: [PATCH 5/6] Ensure local tests are passing From b9e316431a55ce275f1d94b7124a405d0f355a44 Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 22 Aug 2023 17:39:06 -0400 Subject: [PATCH 6/6] re add version bump --- packages/webview_flutter/webview_flutter/CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/CHANGELOG.md b/packages/webview_flutter/webview_flutter/CHANGELOG.md index e46bfea8ec2..2f15f13f24a 100644 --- a/packages/webview_flutter/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter/CHANGELOG.md @@ -1,6 +1,7 @@ ## 4.2.3 -* Fixes the code sample in the dartdocs for `WebViewController.addJavaScriptChannel`. +* Fixes the code sample in the dartdocs for `WebViewController.addJavaScriptChannel`. +* Updates minimum supported SDK version to Flutter 3.7/Dart 2.19. ## 4.2.2