From 554f2ab8e252df8e713e6692f3b5559efccbc2ae Mon Sep 17 00:00:00 2001 From: Raul Vilar Date: Wed, 2 Aug 2023 14:39:09 -0300 Subject: [PATCH 1/4] fix incorrect declaration EncoderProfiles when SDK is lower than 31 --- .../src/main/java/io/flutter/plugins/camera/Camera.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/Camera.java b/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/Camera.java index 09fbd4408be..5e526975172 100644 --- a/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/Camera.java +++ b/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/Camera.java @@ -256,9 +256,8 @@ private void prepareMediaRecorder(String outputFilePath) throws IOException { // TODO(camsim99): Revert changes that allow legacy code to be used when recordingProfile is null // once this has largely been fixed on the Android side. https://github.com/flutter/flutter/issues/119668 - EncoderProfiles recordingProfile = getRecordingProfile(); - if (SdkCapabilityChecker.supportsEncoderProfiles() && recordingProfile != null) { - mediaRecorderBuilder = new MediaRecorderBuilder(recordingProfile, outputFilePath); + if (SdkCapabilityChecker.supportsEncoderProfiles() && getRecordingProfile() != null) { + mediaRecorderBuilder = new MediaRecorderBuilder(getRecordingProfile(), outputFilePath); } else { mediaRecorderBuilder = new MediaRecorderBuilder(getRecordingProfileLegacy(), outputFilePath); } From 532c9e55bacb30b098c8365eb309a8258493d510 Mon Sep 17 00:00:00 2001 From: Raul Vilar Date: Wed, 2 Aug 2023 14:43:25 -0300 Subject: [PATCH 2/4] update CHANGELOG.md --- packages/camera/camera_android/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/camera/camera_android/CHANGELOG.md b/packages/camera/camera_android/CHANGELOG.md index 426731aa7ff..0f68531eacb 100644 --- a/packages/camera/camera_android/CHANGELOG.md +++ b/packages/camera/camera_android/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.10.9 + +* Fixes video record crash on Android versions lower than 12. + ## 0.10.8+5 * Provides a default exposure point if null. From f38efa4a3c27a7e10c226ed273f9edbf615bfa00 Mon Sep 17 00:00:00 2001 From: Raul Vilar Date: Wed, 2 Aug 2023 14:43:59 -0300 Subject: [PATCH 3/4] update pubspec.yaml --- packages/camera/camera_android/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/camera_android/pubspec.yaml b/packages/camera/camera_android/pubspec.yaml index 68e539e3919..dc8af430da0 100644 --- a/packages/camera/camera_android/pubspec.yaml +++ b/packages/camera/camera_android/pubspec.yaml @@ -3,7 +3,7 @@ description: Android implementation of the camera plugin. repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.10.8+5 +version: 0.10.9 environment: sdk: ">=2.18.0 <4.0.0" From 2296c105649849f8496174432c2d0dc1c5098dbd Mon Sep 17 00:00:00 2001 From: Raul Vilar Date: Thu, 17 Aug 2023 23:10:02 -0300 Subject: [PATCH 4/4] fix: change the version number --- packages/camera/camera_android/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/camera_android/CHANGELOG.md b/packages/camera/camera_android/CHANGELOG.md index 0246e676fa9..1c8d6e67e08 100644 --- a/packages/camera/camera_android/CHANGELOG.md +++ b/packages/camera/camera_android/CHANGELOG.md @@ -1,4 +1,4 @@ -## NEXT +## 0.10.8+7 * Fixes video record crash on Android versions lower than 12. * Updates minimum supported SDK version to Flutter 3.7/Dart 2.19.