Skip to content

Commit 044fa3d

Browse files
authored
Fix broken links in documentation (#2817)
[go_router] Make `replace` use `pop` and `push` to generate a new `pageKey` (#2747) * 🐛 Use pop and push in replace to generate a new pageKey * ✅ Test that replace creates a new page key * ⬆️ Increase the version number * ♻️ Move the asserts to the router deleguate * Wrap _debugAssertMatchListNotEmpty in an assert * Update packages/go_router/lib/src/delegate.dart Co-authored-by: John Ryan <[email protected]> Fix broken links in documentation update changelog
1 parent 6f4e339 commit 044fa3d

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

packages/go_router/CHANGELOG.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
1+
## 5.1.9
2+
3+
- Fixes broken links in documentation.
4+
15
## 5.1.8
26

37
- Fixes a bug with `replace` where it was not generated a new `pageKey`.
48

59
## 5.1.7
610

7-
- Adds documentation using dartdoc topics
11+
- Adds documentation using dartdoc topics.
812

913
## 5.1.6
1014

packages/go_router/README.md

-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ See the API documentation for details on the following topics:
3434
- [Transition animations](https://pub.dev/documentation/go_router/latest/topics/Transition%20animations-topic.html)
3535
- [Type-safe routes](https://pub.dev/documentation/go_router/latest/topics/Type-safe%20routes-topic.html)
3636
- [Named routes](https://pub.dev/documentation/go_router/latest/topics/Named%20routes-topic.html)
37-
- [Logging](https://pub.dev/documentation/go_router/latest/topics/Logging-topic.html)
3837
- [Error handling](https://pub.dev/documentation/go_router/latest/topics/Error%20handling-topic.html)
3938

4039
## Migration guides

packages/go_router/doc/get-started.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ For a complete sample, see the [Getting started sample][] in the example directo
3535
For more on how to configure GoRouter, see [Configuration].
3636

3737
[Getting started sample]: https://github.com/flutter/packages/tree/main/packages/go_router/example/lib/main.dart
38-
[Configuration]: https://pub.dev/documentation/go_router/topics/Configuration-topic.html
38+
[Configuration]: https://pub.dev/documentation/go_router/latest/topics/Configuration-topic.html

packages/go_router/doc/redirection.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ example, redirection can be used to display a sign-in screen if the user is not
33
logged in.
44

55
A redirect is a callback of the type
6-
[GoRouterRedirect](go_router/GoRouterRedirect.html). To change incoming location
7-
based on some application state, add a callback to either the GoRouter or
8-
GoRoute constructor:
6+
[GoRouterRedirect](https://pub.dev/documentation/go_router/latest/go_router/GoRouterRedirect.html).
7+
To change incoming location based on some application state, add a callback to
8+
either the GoRouter or GoRoute constructor:
99

1010

1111
```dart

packages/go_router/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: go_router
22
description: A declarative router for Flutter based on Navigation 2 supporting
33
deep linking, data-driven routes and more
4-
version: 5.1.8
4+
version: 5.1.9
55
repository: https://github.com/flutter/packages/tree/main/packages/go_router
66
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22
77

0 commit comments

Comments
 (0)