Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_plugin_tools] Don't require version changes for dev_dependencies #103602

Open
stuartmorgan opened this issue May 12, 2022 · 1 comment
Open
Labels
p: tooling Affects the flutter_plugin_tools package P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@stuartmorgan
Copy link
Contributor

In flutter/plugins#5703 the publishable check thought there needed to be a version change, because pubspec.yaml changed. However, the only changes were to dev_dependencies, which don't need to be published. Ideally we should teach the tooling to know that's okay so it doesn't need overriding. (It would require much deeper analysis than that tooling is currently doing though, so it may not be worth the effort for an edge case.)

@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin p: tooling Affects the flutter_plugin_tools package P3 Issues that are less important to the Flutter project labels May 12, 2022
@stuartmorgan
Copy link
Contributor Author

Now that we have the "is dev only" logic in the tooling, this is where we would want to put that logic (which would now exempt it from both version and changelog changes).

@stuartmorgan stuartmorgan added package flutter/packages repository. See also p: labels. and removed plugin labels Mar 4, 2023
@flutter-triage-bot flutter-triage-bot bot added team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: tooling Affects the flutter_plugin_tools package P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Development

No branches or pull requests

1 participant