Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix backspace crash on Chinese devices #9734

Merged
GaryQian merged 4 commits into from
Jul 10, 2019
Merged

Fix backspace crash on Chinese devices #9734

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f114e9
Fix crash bug
GaryQian Jul 10, 2019
99968fe
Update comments
GaryQian Jul 10, 2019
b62532a
Typo
GaryQian Jul 10, 2019
4fe5a2e
Update comments
GaryQian Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,20 @@ public boolean sendKeyEvent(KeyEvent event) {
// isRTLCharAt() call below is returning blanket direction assumption
// based on the first character in the line.
boolean isRtl = mLayout.isRtlCharAt(mLayout.getLineForOffset(selStart));
if (isRtl) {
Selection.extendRight(mEditable, mLayout);
} else {
Selection.extendLeft(mEditable, mLayout);
try {
if (isRtl) {
Selection.extendRight(mEditable, mLayout);
} else {
Selection.extendLeft(mEditable, mLayout);
}
} catch (IndexOutOfBoundsException e) {
// On Huaewi devices on initial app startup before focus is lost,

@jason-simmons jason-simmons Jul 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "Huawei"

// The Selection.extendLeft and extendRight calls always extend
// from the index of the initial contents of mEditable. This
// try-catch will prevent crashing on Huawei devices by falling
// back to a simple way of deletion, although this a hack and will
// not handle emojis.
Selection.setSelection(mEditable, selStart, selStart - 1);
}
int newStart = clampIndexToEditable(Selection.getSelectionStart(mEditable), mEditable);
int newEnd = clampIndexToEditable(Selection.getSelectionEnd(mEditable), mEditable);
Expand Down