From c39cb646973c9b9eddf55c4ce7c451de6e7ad1e7 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Tue, 20 Aug 2024 19:10:14 -0700 Subject: [PATCH 1/2] docs: use test: all rather than editing .ci.yaml Rather than editing `.ci.yaml` to enable the `linux_web_engine` shard, instead suggest tagging with the `test: all` label, which avoids the risk of accidentally committing an unwanted change to `.ci.yaml` and having to revert the change before landing. This is also more future-proof against further `runIf` additions to `.ci.yaml`. --- ...it-Engine-PRs-with-the-Flutter-framework.md | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md b/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md index 8d82ccff6fb0d..2942495284f2f 100644 --- a/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md +++ b/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md @@ -4,16 +4,26 @@ This documentation describes how to run flutter/flutter presubmit checks on flut ## Overview -1. Enable the web SDK presubmits. +1. Create your engine pull request with the `test: all` label. 2. Wait for all presubmit checks on your flutter/engine PR to be green. 3. Determine the commit hash for your flutter/engine PR. 4. Create and upload a flutter/flutter PR, (OR run tests locally). 5. Wait for flutter/flutter presubmits/tests to run ☕. -6. Edit `.ci.yaml` to uncomment the `runIf` block you commented out above. -## 1. Edit .ci.yaml +## 1. Create your engine pull request with the `test: all` label. -Edit [`.ci.yaml`](https://github.com/flutter/engine/blob/main/.ci.yaml) to comment out the `runIf:` block in `linux_web_engine`. This will ensure Flutter Web artifacts build, otherwise most framework tests will fail during precache. +When creating your PR, add the `test: all` label *before* submitting the PR to +presubmit. This will ensure that all builds required for framework testing are +triggered. + +If you sent out your PR without adding the `test: all` label, add it, then +re-push your branch to re-trigger presubmits. + +By default, not all builds and tests are run in engine presubmits. When our CI +is able to determine that certain shards are unaffected by a change, via a +`runIf` clause in our `.ci.yaml`, for example, it will be skipped. Many +framework tests, however, assume all build products are present and will trigger +a `flutter precache`, which will fail with a 404 on missing build artifacts. ## 2. Wait From 0528e8b181513eebf857534a7f0fd0dbe8329c2b Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Tue, 20 Aug 2024 20:51:03 -0700 Subject: [PATCH 2/2] Add link, tweak wording --- ...t-Engine-PRs-with-the-Flutter-framework.md | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md b/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md index 2942495284f2f..4996e769ff899 100644 --- a/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md +++ b/docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md @@ -13,17 +13,20 @@ This documentation describes how to run flutter/flutter presubmit checks on flut ## 1. Create your engine pull request with the `test: all` label. When creating your PR, add the `test: all` label *before* submitting the PR to -presubmit. This will ensure that all builds required for framework testing are +CI. This will ensure that all builds required for framework testing are triggered. -If you sent out your PR without adding the `test: all` label, add it, then -re-push your branch to re-trigger presubmits. +If you sent out your PR without adding the `test: all` label, you can add it, +then re-push your branch to re-trigger presubmits. -By default, not all builds and tests are run in engine presubmits. When our CI -is able to determine that certain shards are unaffected by a change, via a -`runIf` clause in our `.ci.yaml`, for example, it will be skipped. Many -framework tests, however, assume all build products are present and will trigger -a `flutter precache`, which will fail with a 404 on missing build artifacts. +By default, [not all builds and tests are run][engine_presubmits] in engine +presubmits. When our CI is able to determine that certain shards are unaffected +by a change, via a `runIf` clause in our `.ci.yaml`, for example, it will be +skipped. Many framework tests, however, assume all build products are present +and will trigger a `flutter precache`, which will fail with a 404 on missing +build artifacts. + +[engine_presubmits]: ci/Engine-pre-submits-and-post-submits.md#running-post-submits-eagerly ## 2. Wait