Use getBoundingRects to add support inset MediaQuery/SafeArea when in freeform mode controls are shown. #54294
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package io.flutter.embedding.android; | ||
|
|
||
| import android.app.Activity; | ||
| import android.content.Context; | ||
| import android.graphics.Rect; | ||
| import android.view.Window; | ||
| import android.view.WindowInsets; | ||
| import androidx.annotation.RequiresApi; | ||
| import androidx.annotation.VisibleForTesting; | ||
| import io.flutter.Build; | ||
| import io.flutter.util.ViewUtils; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| /** A delegate class that performs the task of retrieving the bounding rect values. */ | ||
|
Contributor
There was a problem hiding this comment. Is there anything you can add here to let future maintainers know when logic should go into FlutterViewDelegate vs sendViewportMetricsToFlutter |
||
| public class FlutterViewDelegate { | ||
| /** | ||
| * Return the WindowInsets object for the provided Context. Returns null if there is no associated | ||
|
Contributor
There was a problem hiding this comment. Can you document when 2 different context objects might have different windowInsets?
Contributor
Author
There was a problem hiding this comment. Can you explain why this detail is relevant documentation to this method? I'm not sure I see the throughline.
Contributor
There was a problem hiding this comment. The dart docs is a hint for callers and for maintainers to help understand the behavior of the code documented. The existing dart doc, as written, helps a little bit by describing the null behavior but it could be more helpful if it describe when context might change. That is because the caller can know for their use case of FlutterViewDelegate if it matters which context to pass. For example if the android documentation indicates that window insets will always be the same for an app regardless of which of the apps context is used it indicated to the caller that it might be safe in situations when launching another activity to use the application context. However if insets might change across activities maybe because of their window flags then it is important to use one FlutterViewDelate per activity. |
||
| * activity, the window of the associated activity is null, or the root window insets of the | ||
| * activity's window is null. | ||
| */ | ||
| @RequiresApi(api = Build.API_LEVELS.API_23) | ||
| @VisibleForTesting | ||
| public WindowInsets getWindowInsets(Context context) { | ||
| Activity activity = ViewUtils.getActivity(context); | ||
| if (activity == null) { | ||
| return null; | ||
| } | ||
| Window window = activity.getWindow(); | ||
| if (window == null) { | ||
| return null; | ||
| } | ||
| return window.getDecorView().getRootWindowInsets(); | ||
| } | ||
|
|
||
| @RequiresApi(api = Build.API_LEVELS.API_35) | ||
|
reidbaker marked this conversation as resolved.
|
||
| @VisibleForTesting | ||
|
reidbaker marked this conversation as resolved.
Outdated
|
||
| public List<Rect> getCaptionBarInsets(Context context) { | ||
| WindowInsets insets = getWindowInsets(context); | ||
|
reidbaker marked this conversation as resolved.
|
||
| if (insets == null) { | ||
| return Collections.emptyList(); | ||
| } | ||
| return insets.getBoundingRects(WindowInsets.Type.captionBar()); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Digging into go/customizable-window-headers I found APPEARANCE_TRANSPARENT_CAPTION_BAR_BACKGROUND Can you test an app with that flag set vs the default and come up with a recommendation on if we should apply transparent caption bar by default or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should not be considered blocking.