Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added CI step for building with validation layers #42724

Merged
gaaclarke merged 2 commits into from
Jun 13, 2023
Merged

Added CI step for building with validation layers #42724

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d7a27a
Added CI step for building with validation layers
gaaclarke Jun 10, 2023
c2bbe70
added cas_archive:false
gaaclarke Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ci/builders/linux_android_debug_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,27 @@
]
}
},
{
"archives": [],
"drone_dimensions": [
"device_type=none",
"os=Linux"
],
"gn": [
"--android",
"--android-cpu=arm64",
"--no-lto",
"--enable-vulkan-validation-layers"
],
"name": "android_debug_arm64_validation_layers",

@godofredoc godofredoc Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need a "cas_archive": false here. https://github.com/flutter/engine/tree/main/ci/builders#archives

@gaaclarke gaaclarke Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be what I was missing. I was thinking having an empty archive field would be the same thing as this.

"ninja": {
"config": "android_debug_arm64_validation_layers",

@godofredoc godofredoc Jun 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace config here with android_debug_arm64, https://github.com/flutter/engine/tree/main/ci/builders#ninja.

"targets": [
"flutter",
"flutter/shell/platform/android:abi_jars"
]
}
},
{
"archives": [
{
Expand Down