diff --git a/.ci.yaml b/.ci.yaml index f19260fe967a5..78d0e5052a075 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -278,6 +278,7 @@ targets: runIf: - DEPS - .ci.yaml + - .clang-tidy - tools/** - ci/** - "**.h" @@ -298,6 +299,7 @@ targets: runIf: - DEPS - .ci.yaml + - .clang-tidy - tools/** - ci/** - "**.h" @@ -541,6 +543,7 @@ targets: runIf: - DEPS - .ci.yaml + - .clang-tidy - tools/** - ci/** - "**.h" @@ -563,6 +566,7 @@ targets: runIf: - DEPS - .ci.yaml + - .clang-tidy - tools/** - ci/** - "**.h" diff --git a/.clang-tidy b/.clang-tidy index abd87ed614c4f..716f63fbb6f1e 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -2,6 +2,7 @@ # Note: Some of the checks here are used as errors selectively, see # //ci/lint.sh Checks: "bugprone-use-after-move,\ +bugprone-unchecked-optional-access,\ clang-analyzer-*,\ clang-diagnostic-*,\ darwin-*,\ diff --git a/flow/layers/clip_path_layer_unittests.cc b/flow/layers/clip_path_layer_unittests.cc index 4d3489b9238f6..e26be5c209ddb 100644 --- a/flow/layers/clip_path_layer_unittests.cc +++ b/flow/layers/clip_path_layer_unittests.cc @@ -14,6 +14,9 @@ #include "flutter/fml/macros.h" #include "gtest/gtest.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -569,3 +572,5 @@ TEST_F(ClipPathLayerTest, EmptyClipDoesNotCullPlatformView) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/clip_rect_layer_unittests.cc b/flow/layers/clip_rect_layer_unittests.cc index f92d4599361c8..55359b378a707 100644 --- a/flow/layers/clip_rect_layer_unittests.cc +++ b/flow/layers/clip_rect_layer_unittests.cc @@ -12,6 +12,9 @@ #include "flutter/flow/testing/mock_layer.h" #include "flutter/fml/macros.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -545,3 +548,5 @@ TEST_F(ClipRectLayerTest, EmptyClipDoesNotCullPlatformView) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/clip_rrect_layer_unittests.cc b/flow/layers/clip_rrect_layer_unittests.cc index 9bbef5fbb05af..1c3672d7cc616 100644 --- a/flow/layers/clip_rrect_layer_unittests.cc +++ b/flow/layers/clip_rrect_layer_unittests.cc @@ -12,6 +12,9 @@ #include "flutter/flow/testing/mock_layer.h" #include "flutter/fml/macros.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -594,3 +597,5 @@ TEST_F(ClipRRectLayerTest, EmptyClipDoesNotCullPlatformView) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/color_filter_layer_unittests.cc b/flow/layers/color_filter_layer_unittests.cc index f07f47d73e73e..1ec1f35bd0bcc 100644 --- a/flow/layers/color_filter_layer_unittests.cc +++ b/flow/layers/color_filter_layer_unittests.cc @@ -17,6 +17,9 @@ #include "flutter/flow/testing/mock_layer.h" #include "flutter/fml/macros.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -454,3 +457,5 @@ TEST_F(ColorFilterLayerTest, OpacityInheritance) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/container_layer_unittests.cc b/flow/layers/container_layer_unittests.cc index a4c671d05f39d..42317ff9541a2 100644 --- a/flow/layers/container_layer_unittests.cc +++ b/flow/layers/container_layer_unittests.cc @@ -13,6 +13,9 @@ #include "gtest/gtest.h" #include "include/core/SkMatrix.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -762,3 +765,5 @@ TEST_F(ContainerLayerDiffTest, ReplaceLayer) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/display_list_layer_unittests.cc b/flow/layers/display_list_layer_unittests.cc index 137b76d2472fb..956bfe88c12cf 100644 --- a/flow/layers/display_list_layer_unittests.cc +++ b/flow/layers/display_list_layer_unittests.cc @@ -11,6 +11,9 @@ #include "flutter/flow/testing/diff_context_test.h" #include "flutter/fml/macros.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -570,3 +573,5 @@ TEST_F(DisplayListLayerTest, OverflowCachedDisplayListOpacityInheritance) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/display_list_raster_cache_item.cc b/flow/layers/display_list_raster_cache_item.cc index b295c85ea2761..04550e735f899 100644 --- a/flow/layers/display_list_raster_cache_item.cc +++ b/flow/layers/display_list_raster_cache_item.cc @@ -16,6 +16,9 @@ #include "flutter/flow/raster_cache_util.h" #include "third_party/skia/include/gpu/GrDirectContext.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { static bool IsDisplayListWorthRasterizing( @@ -170,3 +173,5 @@ bool DisplayListRasterCacheItem::TryToPrepareRasterCache( }); } } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/image_filter_layer_unittests.cc b/flow/layers/image_filter_layer_unittests.cc index 3d27ac6af7f50..7b32e08571fb2 100644 --- a/flow/layers/image_filter_layer_unittests.cc +++ b/flow/layers/image_filter_layer_unittests.cc @@ -15,6 +15,9 @@ #include "include/core/SkPath.h" #include "third_party/skia/include/effects/SkImageFilters.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -710,3 +713,5 @@ TEST_F(ImageFilterLayerDiffTest, ImageFilterLayerInflatestChildSize) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/layer_raster_cache_item.cc b/flow/layers/layer_raster_cache_item.cc index 75b116e4c2cd7..dd53f6b5802e8 100644 --- a/flow/layers/layer_raster_cache_item.cc +++ b/flow/layers/layer_raster_cache_item.cc @@ -7,6 +7,9 @@ #include "flutter/flow/raster_cache_item.h" #include "flutter/flow/raster_cache_util.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { LayerRasterCacheItem::LayerRasterCacheItem(Layer* layer, @@ -190,3 +193,5 @@ bool LayerRasterCacheItem::Draw(const PaintContext& context, } } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/opacity_layer_unittests.cc b/flow/layers/opacity_layer_unittests.cc index a2a119264bf8b..ca1f1067e87c3 100644 --- a/flow/layers/opacity_layer_unittests.cc +++ b/flow/layers/opacity_layer_unittests.cc @@ -18,6 +18,9 @@ #include "flutter/testing/display_list_testing.h" #include "gtest/gtest.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -742,3 +745,5 @@ TEST_F(OpacityLayerTest, FullyTransparentDoesNotCullPlatformView) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/layers/shader_mask_layer_unittests.cc b/flow/layers/shader_mask_layer_unittests.cc index b5361a54eb09a..4354f8715a1db 100644 --- a/flow/layers/shader_mask_layer_unittests.cc +++ b/flow/layers/shader_mask_layer_unittests.cc @@ -13,6 +13,9 @@ #include "flutter/fml/macros.h" #include "gtest/gtest.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -463,3 +466,5 @@ TEST_F(ShaderMaskLayerTest, SimpleFilterWithRasterCacheLayerNotCached) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/flow/raster_cache_unittests.cc b/flow/raster_cache_unittests.cc index 00b99d05fd524..43c314c7fff33 100644 --- a/flow/raster_cache_unittests.cc +++ b/flow/raster_cache_unittests.cc @@ -24,6 +24,9 @@ #include "third_party/skia/include/core/SkPicture.h" #include "third_party/skia/include/core/SkPictureRecorder.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -885,3 +888,5 @@ TEST_F(RasterCacheTest, RasterCacheKeyIDLayerChildrenIds) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/fml/message_loop_task_queues.cc b/fml/message_loop_task_queues.cc index 61f38751b5ebe..211a7caac8c42 100644 --- a/fml/message_loop_task_queues.cc +++ b/fml/message_loop_task_queues.cc @@ -15,6 +15,9 @@ #include "flutter/fml/task_source.h" #include "flutter/fml/thread_local.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace fml { const size_t TaskQueueId::kUnmerged = ULONG_MAX; @@ -397,3 +400,5 @@ TaskSource::TopTask MessageLoopTaskQueues::PeekNextTaskUnlocked( } } // namespace fml + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/aiks/canvas.cc b/impeller/aiks/canvas.cc index d7e2f7844c141..a4a636da8a30e 100644 --- a/impeller/aiks/canvas.cc +++ b/impeller/aiks/canvas.cc @@ -20,6 +20,9 @@ #include "impeller/entity/geometry/geometry.h" #include "impeller/geometry/path_builder.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { Canvas::Canvas() { @@ -658,3 +661,5 @@ void Canvas::DrawAtlas(const std::shared_ptr& atlas, } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/aiks/canvas_unittests.cc b/impeller/aiks/canvas_unittests.cc index 9c0f07acd406a..ed83f0500a254 100644 --- a/impeller/aiks/canvas_unittests.cc +++ b/impeller/aiks/canvas_unittests.cc @@ -6,6 +6,9 @@ #include "impeller/aiks/canvas.h" #include "impeller/geometry/path_builder.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace testing { @@ -335,3 +338,5 @@ TEST(AiksCanvasTest, PathClipDiffAgainstFullyCoveredCullRect) { } // namespace testing } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/archivist/archivist_unittests.cc b/impeller/archivist/archivist_unittests.cc index dbd210afa0ff4..6e63c5c7e23bf 100644 --- a/impeller/archivist/archivist_unittests.cc +++ b/impeller/archivist/archivist_unittests.cc @@ -11,6 +11,9 @@ #include "impeller/archivist/archive_location.h" #include "impeller/archivist/archivist_fixture.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace testing { @@ -198,3 +201,5 @@ TEST_F(ArchiveTest, CanReadWriteVectorOfArchivables) { } // namespace testing } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/core/runtime_types.cc b/impeller/core/runtime_types.cc index 0c530699ecda3..481ee9253f6ea 100644 --- a/impeller/core/runtime_types.cc +++ b/impeller/core/runtime_types.cc @@ -9,6 +9,8 @@ namespace impeller { size_t RuntimeUniformDescription::GetSize() const { size_t size = dimensions.rows * dimensions.cols * bit_width / 8u; if (array_elements.value_or(0) > 0) { + // Covered by check on the line above. + // NOLINTNEXTLINE(bugprone-unchecked-optional-access) size *= array_elements.value(); } return size; diff --git a/impeller/display_list/dl_image_impeller.cc b/impeller/display_list/dl_image_impeller.cc index 9ba43538e9f87..e58a083d46604 100644 --- a/impeller/display_list/dl_image_impeller.cc +++ b/impeller/display_list/dl_image_impeller.cc @@ -7,6 +7,9 @@ #include "impeller/aiks/aiks_context.h" #include "impeller/entity/contents/filters/filter_contents.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { sk_sp DlImageImpeller::Make(std::shared_ptr texture, @@ -91,3 +94,5 @@ size_t DlImageImpeller::GetApproximateByteSize() const { } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/display_list/skia_conversions.cc b/impeller/display_list/skia_conversions.cc index e488b39a9d4ff..37c8381cf7aa0 100644 --- a/impeller/display_list/skia_conversions.cc +++ b/impeller/display_list/skia_conversions.cc @@ -4,6 +4,9 @@ #include "impeller/display_list/skia_conversions.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace skia_conversions { @@ -177,3 +180,5 @@ std::optional ToPixelFormat(SkColorType type) { } // namespace skia_conversions } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/entity/contents/content_context.cc b/impeller/entity/contents/content_context.cc index 55aa880923ceb..936955790345a 100644 --- a/impeller/entity/contents/content_context.cc +++ b/impeller/entity/contents/content_context.cc @@ -16,6 +16,9 @@ #include "impeller/renderer/render_target.h" #include "impeller/tessellator/tessellator.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { void ContentContextOptions::ApplyToPipelineDescriptor( @@ -409,3 +412,5 @@ void ContentContext::SetWireframe(bool wireframe) { } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/entity/contents/contents.cc b/impeller/entity/contents/contents.cc index 2427125a160c6..127e1dcbdb4be 100644 --- a/impeller/entity/contents/contents.cc +++ b/impeller/entity/contents/contents.cc @@ -15,6 +15,9 @@ #include "impeller/renderer/command_buffer.h" #include "impeller/renderer/render_pass.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { ContentContextOptions OptionsFromPass(const RenderPass& pass) { @@ -148,3 +151,5 @@ void Contents::SetColorSourceSize(Size size) { } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/entity/contents/filters/filter_contents.cc b/impeller/entity/contents/filters/filter_contents.cc index d9e566c50a24d..e2307848f3145 100644 --- a/impeller/entity/contents/filters/filter_contents.cc +++ b/impeller/entity/contents/filters/filter_contents.cc @@ -28,6 +28,9 @@ #include "impeller/renderer/command_buffer.h" #include "impeller/renderer/render_pass.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { std::shared_ptr FilterContents::MakeDirectionalGaussianBlur( @@ -269,3 +272,5 @@ Matrix FilterContents::GetTransform(const Matrix& parent_transform) const { } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/entity/contents/tiled_texture_contents.cc b/impeller/entity/contents/tiled_texture_contents.cc index cb9275da08d16..cab8d872918fa 100644 --- a/impeller/entity/contents/tiled_texture_contents.cc +++ b/impeller/entity/contents/tiled_texture_contents.cc @@ -14,6 +14,9 @@ #include "impeller/renderer/render_pass.h" #include "impeller/renderer/sampler_library.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { static std::optional TileModeToAddressMode( @@ -195,3 +198,5 @@ bool TiledTextureContents::Render(const ContentContext& renderer, } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/entity/entity_pass.cc b/impeller/entity/entity_pass.cc index b929ab54d52d9..c28a598697ba3 100644 --- a/impeller/entity/entity_pass.cc +++ b/impeller/entity/entity_pass.cc @@ -34,6 +34,9 @@ #include "impeller/entity/contents/checkerboard_contents.h" #endif // IMPELLER_DEBUG +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { EntityPass::EntityPass() = default; @@ -910,3 +913,5 @@ void EntityPass::SetEnableOffscreenCheckerboard(bool enabled) { } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/entity/entity_unittests.cc b/impeller/entity/entity_unittests.cc index abd4d3d1ddb91..6d92c3edcaffe 100644 --- a/impeller/entity/entity_unittests.cc +++ b/impeller/entity/entity_unittests.cc @@ -54,6 +54,9 @@ #include "third_party/imgui/imgui.h" #include "third_party/skia/include/core/SkTextBlob.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace testing { @@ -2637,3 +2640,5 @@ TEST_P(EntityTest, PointFieldGeometryDivisions) { } // namespace testing } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/geometry/geometry_unittests.cc b/impeller/geometry/geometry_unittests.cc index fc999fd803910..654cf8e6601da 100644 --- a/impeller/geometry/geometry_unittests.cc +++ b/impeller/geometry/geometry_unittests.cc @@ -20,6 +20,9 @@ #include "impeller/geometry/scalar.h" #include "impeller/geometry/size.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace testing { @@ -2203,3 +2206,5 @@ TEST(GeometryTest, HalfConversions) { } // namespace testing } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/playground/imgui/imgui_impl_impeller.cc b/impeller/playground/imgui/imgui_impl_impeller.cc index b3059557ea30a..24f367168bfa5 100644 --- a/impeller/playground/imgui/imgui_impl_impeller.cc +++ b/impeller/playground/imgui/imgui_impl_impeller.cc @@ -34,6 +34,9 @@ #include "impeller/renderer/render_pass.h" #include "impeller/renderer/sampler_library.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + struct ImGui_ImplImpeller_Data { std::shared_ptr context; std::shared_ptr font_texture; @@ -269,3 +272,5 @@ void ImGui_ImplImpeller_RenderDrawData(ImDrawData* draw_data, index_buffer_offset += draw_list_idx_bytes; } } + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/renderer/capabilities.cc b/impeller/renderer/capabilities.cc index d0531f5f265b2..44721ce836025 100644 --- a/impeller/renderer/capabilities.cc +++ b/impeller/renderer/capabilities.cc @@ -4,6 +4,9 @@ #include "impeller/renderer/capabilities.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { Capabilities::Capabilities() = default; @@ -221,3 +224,5 @@ std::unique_ptr CapabilitiesBuilder::Build() { } } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/renderer/renderer_unittests.cc b/impeller/renderer/renderer_unittests.cc index 50250461f7bf1..39d01c62eba4e 100644 --- a/impeller/renderer/renderer_unittests.cc +++ b/impeller/renderer/renderer_unittests.cc @@ -39,6 +39,9 @@ #include "impeller/tessellator/tessellator.h" #include "third_party/imgui/imgui.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace testing { @@ -1043,3 +1046,5 @@ TEST_P(RendererTest, VertexBufferBuilder) { } // namespace testing } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/impeller/typographer/typographer_unittests.cc b/impeller/typographer/typographer_unittests.cc index a425612ea8421..ad18242615a55 100644 --- a/impeller/typographer/typographer_unittests.cc +++ b/impeller/typographer/typographer_unittests.cc @@ -11,6 +11,9 @@ #include "third_party/skia/include/core/SkData.h" #include "third_party/skia/include/core/SkTextBlob.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace impeller { namespace testing { @@ -289,3 +292,5 @@ TEST_P(TypographerTest, MaybeHasOverlapping) { } // namespace testing } // namespace impeller + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/shell/common/rasterizer.cc b/shell/common/rasterizer.cc index cc613dcf89679..4a6f95f6da6b3 100644 --- a/shell/common/rasterizer.cc +++ b/shell/common/rasterizer.cc @@ -25,6 +25,9 @@ #include "third_party/skia/include/gpu/ganesh/SkSurfaceGanesh.h" #include "third_party/skia/include/utils/SkBase64.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { // The rasterizer will tell Skia to purge cached resources that have not been @@ -867,3 +870,5 @@ Rasterizer::Screenshot::Screenshot(const Screenshot& other) = default; Rasterizer::Screenshot::~Screenshot() = default; } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/shell/common/shell.cc b/shell/common/shell.cc index c5785908215eb..1d7537cb4f391 100644 --- a/shell/common/shell.cc +++ b/shell/common/shell.cc @@ -33,6 +33,9 @@ #include "third_party/skia/include/utils/SkBase64.h" #include "third_party/tonic/common/log.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { constexpr char kSkiaChannel[] = "flutter/skia"; @@ -2121,3 +2124,5 @@ Shell::GetConcurrentWorkerTaskRunner() const { } } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/shell/common/switches_unittests.cc b/shell/common/switches_unittests.cc index 4d96729ec9899..0307b9d62bf91 100644 --- a/shell/common/switches_unittests.cc +++ b/shell/common/switches_unittests.cc @@ -10,6 +10,9 @@ #include "gtest/gtest.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -114,3 +117,5 @@ TEST(SwitchesTest, NoEnableImpeller) { } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/shell/platform/embedder/embedder_external_view_embedder.cc b/shell/platform/embedder/embedder_external_view_embedder.cc index 380b404a13046..52ccea6ef2f75 100644 --- a/shell/platform/embedder/embedder_external_view_embedder.cc +++ b/shell/platform/embedder/embedder_external_view_embedder.cc @@ -11,6 +11,9 @@ #include "flutter/shell/platform/embedder/embedder_render_target.h" #include "third_party/skia/include/gpu/GrDirectContext.h" +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { EmbedderExternalViewEmbedder::EmbedderExternalViewEmbedder( @@ -264,3 +267,5 @@ void EmbedderExternalViewEmbedder::SubmitFrame( } } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access) diff --git a/shell/platform/embedder/tests/embedder_test_backingstore_producer.cc b/shell/platform/embedder/tests/embedder_test_backingstore_producer.cc index 114885bebaec0..21cbdec7e5e7c 100644 --- a/shell/platform/embedder/tests/embedder_test_backingstore_producer.cc +++ b/shell/platform/embedder/tests/embedder_test_backingstore_producer.cc @@ -17,6 +17,9 @@ #include #include +// TODO(zanderso): https://github.com/flutter/flutter/issues/127701 +// NOLINTBEGIN(bugprone-unchecked-optional-access) + namespace flutter { namespace testing { @@ -380,3 +383,5 @@ bool EmbedderTestBackingStoreProducer::CreateVulkanImage( } // namespace testing } // namespace flutter + +// NOLINTEND(bugprone-unchecked-optional-access)