Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Convert Safari and Firefox wheel delta to physical pixels. #35428

Merged
auto-submit merged 3 commits into from
Sep 29, 2022
+107 −6
Merged

Convert Safari and Firefox wheel delta to physical pixels. #35428

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d6c1ad
Convert Safari and Firefox wheel delta to physical pixels.
knopp Aug 16, 2022
8c2a62e
add tests
mdebbar Sep 29, 2022
f6a44bc
Merge branch 'main' into fix_safari_wheel_delta
mdebbar Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/web_ui/lib/src/engine/pointer_binding.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,14 @@ mixin _WheelEventListenerMixin on _BaseAdapter {
deltaY *= ui.window.physicalSize.height;
break;
case domDeltaPixel:
if (operatingSystem == OperatingSystem.macOs &&
browserEngine != BrowserEngine.blink) {
// Safari and Firefox seems to report delta in logical pixels while
// Chrome uses physical pixels.
deltaX *= ui.window.devicePixelRatio;
deltaY *= ui.window.devicePixelRatio;
}
break;
default:
break;
}
Expand Down