Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Pass angles for SweepGradient in degrees, not radians #21677

Merged
harryterkelsen merged 7 commits into from
Dec 12, 2020
Merged

Pass angles for SweepGradient in degrees, not radians #21677

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26202c1
Pass angles for SweepGradient in degrees, not radians
harryterkelsen Oct 7, 2020
85a5c35
Merge branch 'master' into canvaskit-sweep-gradient
harryterkelsen Dec 10, 2020
1a5aff7
add test
harryterkelsen Dec 11, 2020
8e77199
Remove write flag
harryterkelsen Dec 11, 2020
abae9a6
Skip screenshot tests on safari and firefox
harryterkelsen Dec 11, 2020
b0f4c56
Remove unused imports
harryterkelsen Dec 11, 2020
91463f9
Update goldens lock
harryterkelsen Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/web_ui/lib/src/engine/canvaskit/shader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class CkGradientSweep extends CkShader implements ui.Gradient {

@override
SkShader createDefault() {
const double toDegrees = 180.0 / math.pi;
return canvasKit.SkShader.MakeSweepGradient(
center.dx,
center.dy,
Expand All @@ -43,8 +44,8 @@ class CkGradientSweep extends CkShader implements ui.Gradient {
toSkTileMode(tileMode),
matrix4 != null ? toSkMatrixFromFloat32(matrix4!) : null,
0,
startAngle,
endAngle,
toDegrees * startAngle,
toDegrees * endAngle,
);
}

Expand Down