Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added some tests after the fact for #17499 #17714

Merged
gaaclarke merged 3 commits into from
Apr 15, 2020
Merged

Added some tests after the fact for #17499 #17714

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c5227e
Added some tests after the fact for #17499.
gaaclarke Apr 14, 2020
1acf990
formatter and removed assert details strings
gaaclarke Apr 14, 2020
121cefd
Merge branch 'master' into add-tests-17499
gaaclarke Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions shell/platform/darwin/ios/framework/Source/SemanticsObjectTest.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,30 @@ - (void)testCreate {
XCTAssertNotNil(object);
}

- (void)testSetChildren {
fml::WeakPtrFactory<flutter::AccessibilityBridgeIos> factory(
new flutter::MockAccessibilityBridge());
fml::WeakPtr<flutter::AccessibilityBridgeIos> bridge = factory.GetWeakPtr();
SemanticsObject* parent = [[SemanticsObject alloc] initWithBridge:bridge uid:0];
SemanticsObject* child = [[SemanticsObject alloc] initWithBridge:bridge uid:1];
parent.children = @[child];
XCTAssertEqual(parent, child.parent, @"");

@jmagman jmagman Apr 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave off the @"" for all the XCAsserts, the message is optional.

@gaaclarke gaaclarke Apr 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

parent.children = @[];
XCTAssertNil(child.parent, @"");
}

- (void)testReplaceChildAtIndex {
fml::WeakPtrFactory<flutter::AccessibilityBridgeIos> factory(
new flutter::MockAccessibilityBridge());
fml::WeakPtr<flutter::AccessibilityBridgeIos> bridge = factory.GetWeakPtr();
SemanticsObject* parent = [[SemanticsObject alloc] initWithBridge:bridge uid:0];
SemanticsObject* child1 = [[SemanticsObject alloc] initWithBridge:bridge uid:1];
SemanticsObject* child2 = [[SemanticsObject alloc] initWithBridge:bridge uid:2];
parent.children = @[child1];
[parent replaceChildAtIndex:0 withChild:child2];
XCTAssertNil(child1.parent, @"");
XCTAssertEqual(parent, child2.parent, @"");
XCTAssertEqualObjects(parent.children, @[child2], @"");
}

@end
2 changes: 2 additions & 0 deletions testing/ios/IosUnitTests/build_and_run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/sh

set -e

@jmagman jmagman Apr 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


FLUTTER_ENGINE=ios_debug_sim_unopt

if [ $# -eq 1 ]; then
Expand Down