Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

In tests run dart code on ui(rather than on platform) thread. #17686

Merged
fluttergithubbot merged 4 commits into from
Apr 13, 2020
+2 −2
Merged

In tests run dart code on ui(rather than on platform) thread. #17686

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25430a1
Run dart code on ui(rather than on platform) thread.
aam Apr 13, 2020
457c632
format
aam Apr 13, 2020
5ec72c4
Merge branch 'master' into run-test-on-ui
aam Apr 13, 2020
62442d5
Move all code that sets up and isolate to UI thread as well
aam Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions testing/dart_isolate_runner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ void RunDartCodeInIsolate(DartVMRef& vm_ref,
return;
}

if (!root_isolate->get()->Run(entrypoint, args,
settings.root_isolate_create_callback)) {
if (!root_isolate->RunInIsolateScope([&] {
return root_isolate->get()->Run(entrypoint, args,
settings.root_isolate_create_callback);
})) {
FML_LOG(ERROR) << "Could not run the method \"" << entrypoint
<< "\" in the isolate.";
return;
Expand Down