From 8e157ec9be0a777f765d522778c6c7869ce0d8a1 Mon Sep 17 00:00:00 2001 From: Yegor Jbanov Date: Wed, 5 Feb 2020 17:31:37 -0800 Subject: [PATCH 1/2] fix bad reference to maxDiffRatePercent --- lib/web_ui/test/golden_tests/engine/canvas_context_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart b/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart index 31ce13fc207be..e5a79f466b4be 100644 --- a/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart +++ b/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart @@ -29,7 +29,7 @@ void main() async { try { sceneElement.append(engineCanvas.rootElement); html.document.body.append(sceneElement); - await matchGoldenFile('$fileName.png', region: region, maxDiffRate: 0.1); + await matchGoldenFile('$fileName.png', region: region, maxDiffRatePercent: 0.1); } finally { // The page is reused across tests, so remove the element after taking the // Scuba screenshot. From 513a9fa8c3abcff916eee5d0dcfbb4c625e30f82 Mon Sep 17 00:00:00 2001 From: Yegor Jbanov Date: Wed, 5 Feb 2020 17:39:26 -0800 Subject: [PATCH 2/2] back to 10% --- lib/web_ui/test/golden_tests/engine/canvas_context_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart b/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart index e5a79f466b4be..c8a407f3d0142 100644 --- a/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart +++ b/lib/web_ui/test/golden_tests/engine/canvas_context_test.dart @@ -29,7 +29,8 @@ void main() async { try { sceneElement.append(engineCanvas.rootElement); html.document.body.append(sceneElement); - await matchGoldenFile('$fileName.png', region: region, maxDiffRatePercent: 0.1); + // TODO(yjbanov): 10% diff rate is excessive. Update goldens. + await matchGoldenFile('$fileName.png', region: region, maxDiffRatePercent: 10); } finally { // The page is reused across tests, so remove the element after taking the // Scuba screenshot.