This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Commit b192a52
authored
[macOS] Add TODOs to remove AppKit bug workaround (#54764)
In #40241, I added a workaround for an AppKit bug wherein mouseDown/Up events were ignored when the *Reduced Transparency* accessibility setting was enabled, and the view was hosted in an `NSPopover`.
I filed a Radar and Apple reported the bug fixed in macOS 13.3.1.
When we drop support for macOS 12 in Flutter, we should remove the workaround.
So long as nothing else has been added to these methods at that time, the method overrides themselves should be removed, so that we fall back to the default behaviour.
See: http://www.openradar.me/FB12050037
See: https://developer.apple.com/documentation/appkit/nsresponder/1535349-mouseup
Issue: flutter/flutter#154063
Issue: flutter/flutter#115015
No tests modified since this only adds a comment.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style1 parent 77fa544 commit b192a52
File tree
1 file changed
+6
-0
lines changed- shell/platform/darwin/macos/framework/Source
1 file changed
+6
-0
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
300 | 303 | | |
301 | 304 | | |
302 | 305 | | |
| |||
311 | 314 | | |
312 | 315 | | |
313 | 316 | | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
314 | 320 | | |
315 | 321 | | |
316 | 322 | | |
| |||
0 commit comments