From 93cedbdcb974e6fbea505d69209f145c859c5f97 Mon Sep 17 00:00:00 2001 From: Jia Hao Goh Date: Tue, 3 Oct 2023 04:39:44 +0800 Subject: [PATCH] Don't define `CanvasRecorder` if `IMPELLER_TRACE_CANVAS` is not set --- impeller/aiks/canvas_recorder.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/impeller/aiks/canvas_recorder.h b/impeller/aiks/canvas_recorder.h index 56601207f86ad..62711c13fcc92 100644 --- a/impeller/aiks/canvas_recorder.h +++ b/impeller/aiks/canvas_recorder.h @@ -47,6 +47,9 @@ enum CanvasRecorderOp : uint16_t { DrawAtlas, }; +// Canvas recorder should only be used when IMPELLER_TRACE_CANVAS is defined +// (never in production code). +#ifdef IMPELLER_TRACE_CANVAS /// Static polymorphic replacement for impeller::Canvas that records methods /// called on an impeller::Canvas and forwards it to a real instance. /// TODO(https://github.com/flutter/flutter/issues/135718): Move this recorder @@ -55,12 +58,6 @@ enum CanvasRecorderOp : uint16_t { template class CanvasRecorder { public: -#ifndef IMPELLER_TRACE_CANVAS - // Canvas recorder should only be used when IMPELLER_TRACE_CANVAS is defined - // (never in production code). - static_assert(false); -#endif - CanvasRecorder() : canvas_() { serializer_.Write(CanvasRecorderOp::New); } explicit CanvasRecorder(Rect cull_rect) : canvas_(cull_rect) { @@ -286,5 +283,6 @@ class CanvasRecorder { Canvas canvas_; Serializer serializer_; }; +#endif } // namespace impeller