Codearena findings 8, No related function to set fee protocol

Author: af-afk

pkg/seawater/proptest-regressions/lib.txt

@@ -0,0 +1,9 @@
+# Seeds for failure cases proptest has generated in the past. It is
+# automatically read and these particular cases re-run before any
+# novel cases are generated.
+#
+# It is recommended to check this file in to source control so that
+# everyone who runs the test benefits from these saved cases.
+cc 5262a65e4d12e6199dd5ff8c169e89525fe14e27dd5752dd83f955e6a74f7ee2 # shrinks to fee_protocol_0 = 0, fee_protocol_1 = 0
+cc 9e08af991e5365be828ac5d271364b9ee4e5c9a7ab10a60830f95124a9f506fd # shrinks to fee_protocol_0 = 0, fee_protocol_1 = 11
+cc d8dba58868686611d78c8e8e10524b381a32134aa4f528793e995e826ff272b6 # shrinks to fee_protocol_0 = 4, fee_protocol_1 = 4

pkg/seawater/src/error.rs

@@ -245,6 +245,10 @@ pub enum Error {
     // 44 (0x2c)
     #[error("Swap sending fee taking overflow")]
     TransferToSenderSub,
+
+    // 45 (0x2d)
+    #[error("Bad protocol fee was attempted to be set")]
+    BadFeeProtocol
 }
 
 impl From<Error> for Vec<u8> {

pkg/seawater/src/lib.rs

@@ -999,9 +999,12 @@ impl Pools {
             Error::SeawaterAdminOnly
         );
 
-        self.pools
-            .setter(pool)
-            .init(price, fee, tick_spacing, max_liquidity_per_tick)?;
+        self.pools.setter(pool).init(
+            price,
+            fee,
+            tick_spacing,
+            max_liquidity_per_tick,
+        )?;
 
         // get the decimals for the asset so we can log it's decimals for the indexer
 
@@ -1080,6 +1083,36 @@ impl Pools {
         Ok(())
     }
 
+    pub fn set_fee_protocol(
+        &mut self,
+        pool: Address,
+        fee_protocol_0: u8,
+        fee_protocol_1: u8,
+    ) -> Result<(), Revert> {
+        assert_eq_or!(
+            msg::sender(),
+            self.seawater_admin.get(),
+            Error::SeawaterAdminOnly
+        );
+
+        let is_fee_valid = (fee_protocol_0 == 0 || (fee_protocol_0 >= 4 && fee_protocol_0 <= 10))
+            && (fee_protocol_1 == 0 || (fee_protocol_1 >= 4 && fee_protocol_1 <= 10));
+
+        assert_or!(is_fee_valid, Error::BadFeeProtocol);
+
+        let fee_protocol = fee_protocol_0 + (fee_protocol_1 << 4);
+
+        self.pools.setter(pool).set_fee_protocol(fee_protocol);
+
+        #[cfg(feature = "log-events")]
+        evm::log(events::NewFees {
+            pool,
+            feeProtocol: fee_protocol,
+        });
+
+        Ok(())
+    }
+
     /// Update the NFT manager that has trusted access to moving tokens on
     /// behalf of users.
     #[allow(non_snake_case)]

pkg/seawater/src/pool.rs

@@ -639,6 +639,10 @@ impl StoragePool {
         self.sqrt_price.set(new_price);
     }
 
+    pub fn set_fee_protocol(&mut self, fee_protocol: u8) {
+        self.fee_protocol.set(U8::lib(&fee_protocol));
+    }
+
     pub fn get_enabled(&self) -> bool {
         self.enabled.get()
     }

pkg/seawater/tests/lib.rs

@@ -786,3 +786,34 @@ fn ethers_suite_swapping_with_permit2_blobs_no_permit2() {
         },
     );
 }
+
+mod proptesting {
+    use proptest::prelude::*;
+
+    use super::*;
+
+    fn match_fees(x: u8, y: u8) -> bool {
+        match (x, y) {
+            (0, 0) | (0, 1) | (1, 5) | (1, 6) | (1, 7) | (1, 8) | (1, 9) | (1, 10) => true,
+            _ => false,
+        }
+    }
+
+    proptest! {
+        #[test]
+        fn test_fee_protocol(fee_protocol_0 in any::<u8>(), fee_protocol_1 in any::<u8>()) {
+            test_utils::with_storage::<_, Pools, _>(
+                None,
+                None,
+                None,
+                None,
+                |contract| {
+
+                let should_work = match_fees(fee_protocol_0, fee_protocol_1);
+
+                let r = contract.set_fee_protocol(Address::ZERO, fee_protocol_0, fee_protocol_1);
+                assert!((r.is_ok() && should_work) || (r.is_err() && !should_work));
+            });
+        }
+    }
+}

pkg/sol/ISeawaterEvents.sol

@@ -122,4 +122,13 @@ interface ISeawaterEvents {
         uint256 amount1,
         int32 finalTick
     );
+
+    /// @notice new fees were set!
+    /// @param pool that the fees are set for.
+    /// @param fee for the pool given
+    /// @param feeProtocol that's taken by the protocol
+    event NewFees(
+        address indexed pool,
+        uint8 indexed feeProtocol
+    );
 }