Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluentd] Fix CI tests file #440

Closed
dioguerra opened this issue Nov 15, 2023 · 5 comments · May be fixed by #362
Closed

[fluentd] Fix CI tests file #440

dioguerra opened this issue Nov 15, 2023 · 5 comments · May be fixed by #362

Comments

@dioguerra
Copy link
Collaborator

CI is trying to run test with file at templates/tests/test-connection.yaml but missing service.port value makes it fail.

We need to update the tests to take into account if fluentd ingest server is working/exposed and skip or do other tests otherwise.

This section here: https://github.com/fluent/helm-charts/blob/2ffb2ed7562618996d971709ba5132b8fb8745bc/charts/fluentd/templates/tests/test-connection.yaml#L13C20-L14C78

And here:

helm-charts/charts/fluentd/values.yaml

Line 208 in 2ffb2ed

ports: []

This was referenced Nov 15, 2023
Merged
Open
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Don't wait for elastic to be up. (fluent#440)
a445c74
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Add metrics port definition so probes can work. (fluent#440)
d8e472d
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Correct basic test to pass in the default case. (fluent#440)
d1dfd93
@pecastro pecastro mentioned this issue Nov 16, 2023
Merged
@pecastro
Copy link
Contributor

@dioguerra Without knowing exactly what your CI runs I had to infer a few things.
The external case of testing the ingress is a bit more complicated as that will require adding a source to the existing config and do some expectation of which kind of protocol you'll have presented to the outside.

pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Correct basic test to pass in the default case. (fluent#440)
4d6a89c
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Don't wait for elastic to be up. (fluent#440)
70890fa 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Add metrics port definition so probes can work. (fluent#440)
5549856 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Correct basic test to pass in the default case. (fluent#440)
b3ce29f 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
WIP: Sleep for a bit. (fluent#440)
a377f7f 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Wait a bit for fluentd to be really up. (fluent#440)
71f6215 
Signed-off-by: Paulo E. Castro <[email protected]>
@pecastro
Copy link
Contributor

@dioguerra Without knowing exactly what your CI runs I had to infer a few things. The external case of testing the ingress is a bit more complicated as that will require adding a source to the existing config and do some expectation of which kind of protocol you'll have presented to the outside.

Duuhhh .... It was there in ct.yaml. (facepalm)

pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Wait a bit for fluentd to be really up. (fluent#440)
29db732 
It will time-out after 5 min if things are really broken in line with
the helm test default.

Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Don't wait for elastic to be up. (fluent#440)
4115cf7 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Add metrics port definition so probes can work. (fluent#440)
5d1a323 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Correct basic test to pass in the default case. (fluent#440)
5703c20 
Signed-off-by: Paulo E. Castro <[email protected]>
pecastro added a commit to pecastro/fluent-helm-charts that referenced this issue Nov 16, 2023
@pecastro
Wait a bit for fluentd to be really up. (fluent#440)
4a505ec 
It will time-out after 5 min if things are really broken in line with
the helm test default.

Signed-off-by: Paulo E. Castro <[email protected]>
@dioguerra
Copy link
Collaborator Author

Hey, thanks for your contribution. No worries, some people are worse (me) :)
Give me some time to test it out...

@pecastro
Copy link
Contributor

@dioguerra Ping ...

@dioguerra
Copy link
Collaborator Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fluentd): add image reference by digest Boojapho/fluent-helm-charts
2 participants
@pecastro @dioguerra