-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fluentd] Fix CI tests file #440
Comments
@dioguerra Without knowing exactly what your CI runs I had to infer a few things. |
Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
Duuhhh .... It was there in ct.yaml. (facepalm) |
It will time-out after 5 min if things are really broken in line with the helm test default. Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
Signed-off-by: Paulo E. Castro <[email protected]>
It will time-out after 5 min if things are really broken in line with the helm test default. Signed-off-by: Paulo E. Castro <[email protected]>
Hey, thanks for your contribution. No worries, some people are worse (me) :) |
@dioguerra Ping ... |
Fixed |
CI is trying to run test with file at templates/tests/test-connection.yaml but missing service.port value makes it fail.
We need to update the tests to take into account if fluentd ingest server is working/exposed and skip or do other tests otherwise.
This section here: https://github.com/fluent/helm-charts/blob/2ffb2ed7562618996d971709ba5132b8fb8745bc/charts/fluentd/templates/tests/test-connection.yaml#L13C20-L14C78
And here:
helm-charts/charts/fluentd/values.yaml
Line 208 in 2ffb2ed
The text was updated successfully, but these errors were encountered: