Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WEBrick because it is no longer recommended for production use #4648

Open
sparrowt opened this issue Sep 26, 2024 · 6 comments
Open
Labels
enhancement Feature request or improve operations help wanted We need your help!

Comments

@sparrowt
Copy link

Describe the bug

Fluentd depends on webrick and uses it in quite a few places and thus although it's no longer included in ruby, it is required (e.g. the dockerfile installs ruby-webrick).

There have been a fair few CVEs reported for webrick in recent years, but more worrying is that in response to a recent security vulnerability report, one of the maintainers said "webrick is not for production".

If fluentd contines to rely on this, it feels risky (e.g. maybe future reports may not be patched so quickly / at all).

Perhaps it would be wise to migrate each usage away from webrick to a production-suitable replacement?

To Reproduce

Install fluentd - you will not be able to do this without also installing webrick.

Expected behavior

We should move away from production use of a package which the maintainers no longer recommend for production use.

Your Environment

- Fluentd version: all recent versions
- Package version: N/A
- Operating system: N/A
- Kernel version: N/A

Your Configuration

Any configuration.

Your Error Log

N/A

Additional context

No response

@daipom daipom added enhancement Feature request or improve operations and removed waiting-for-triage labels Sep 27, 2024
@daipom daipom changed the title Fluentd relies on webrick which is no longer recommended for production use Replace WEBrick because it is no longer recommended for production use Sep 27, 2024
@daipom daipom added the help wanted We need your help! label Sep 27, 2024
@daipom
Copy link
Contributor

daipom commented Sep 27, 2024

Thanks for your report.
This is more likely enhancement request rather than bug report.
I think we need more opinions and ideas.

@Athishpranav2003
Copy link
Contributor

@daipom i saw this alternative
https://github.com/socketry/falcon

Not sure if there are other alternatives, need to research more

@daipom
Copy link
Contributor

daipom commented Oct 2, 2024

@Athishpranav2003 Thanks!
So, Falcon is an option for us!

Sorry, since I'm unfamiliar with these libraries and don't have much time this month, I cannot say for sure about the direction now.

@Athishpranav2003
Copy link
Contributor

It's similar for me
Maybe others active in Ruby community can give some comments on this
@Watson1978 ?

@Watson1978
Copy link
Contributor

Fluentd has been used async-http and webrick for http server in in_http and RPC.
I think it would be better to integrate them into one library (async-http, falcon or another).

@dentarg
Copy link

dentarg commented Oct 2, 2024

The most popular Ruby web server is Puma: https://github.com/puma/puma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations help wanted We need your help!
Projects
None yet
Development

No branches or pull requests

5 participants