-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency: Update Webrick version limitation #4060
Comments
If this looks OK, I will do this.
|
I think |
Thanks for the comment! I will do this. You mean gem.add_runtime_dependency("webrick", ["~> 1.4"]) or gem.add_runtime_dependency("webrick", ["< 2.0"]) ? If so, I'd prefer the latter. |
|
Sorry, I misunderstood the operator https://thoughtbot.com/blog/rubys-pessimistic-operator Thanks for the advise! I will use |
Is your feature request related to a problem? Please describe.
Currently, the version of
Webrick
is limited as follows.fluentd/fluentd.gemspec
Line 31 in 34f2c55
Recently,
Webrick
v1.8 is released:https://github.com/ruby/webrick/releases
So we need to check if we can update the current version limitation.
As it is, plugins using the latest version of
Webrick
tries to bundle the Fluentd v1.12.1.Describe the solution you'd like
Fix as follows on the feature branch and check the CI.
or
If there is no problem, we merge it.
Describe alternatives you've considered
All plugins using
Webrick
also limits the version in the same way as Fluentd.Additional context
No response
The text was updated successfully, but these errors were encountered: