Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Update Webrick version limitation #4060

Closed
daipom opened this issue Feb 17, 2023 · 5 comments · Fixed by #4061
Closed

Dependency: Update Webrick version limitation #4060

daipom opened this issue Feb 17, 2023 · 5 comments · Fixed by #4061
Assignees

Comments

@daipom
Copy link
Contributor

daipom commented Feb 17, 2023

Is your feature request related to a problem? Please describe.

Currently, the version of Webrick is limited as follows.

Recently, Webrick v1.8 is released:

https://github.com/ruby/webrick/releases

So we need to check if we can update the current version limitation.

As it is, plugins using the latest version of Webrick tries to bundle the Fluentd v1.12.1.

Describe the solution you'd like

Fix as follows on the feature branch and check the CI.

-  gem.add_runtime_dependency("webrick", [">= 1.4.2", "< 1.8.0"])
+  gem.add_runtime_dependency("webrick", [">= 1.4.2"])

or

-  gem.add_runtime_dependency("webrick", [">= 1.4.2", "< 1.8.0"])
+  gem.add_runtime_dependency("webrick", [">= 1.4.2", "< 1.9.0"])

If there is no problem, we merge it.

Describe alternatives you've considered

All plugins using Webrick also limits the version in the same way as Fluentd.

Additional context

No response

@daipom daipom changed the title Dependency: Update webrick version limitation Dependency: Update Webrick version limitation Feb 17, 2023
@daipom
Copy link
Contributor Author

daipom commented Feb 17, 2023

If this looks OK, I will do this.

Fix as follows on the feature branch and check the CI.

@ashie
Copy link
Member

ashie commented Feb 17, 2023

-  gem.add_runtime_dependency("webrick", [">= 1.4.2", "< 1.8.0"])
+  gem.add_runtime_dependency("webrick", [">= 1.4.2", "< 1.9.0"])

I think ~> 1.4 or < 2.0 is enough for this.

@daipom daipom self-assigned this Feb 17, 2023
@daipom
Copy link
Contributor Author

daipom commented Feb 17, 2023

Thanks for the comment! I will do this.

You mean

gem.add_runtime_dependency("webrick", ["~> 1.4"])

or

gem.add_runtime_dependency("webrick", ["< 2.0"])

?

If so, I'd prefer the latter.

@kenhys
Copy link
Contributor

kenhys commented Feb 17, 2023

~> 1.4 bounds to 1.4, 1.5, 1.6 .... 1.9 and so on. thus it is almost equal to < 2.0 practically. (< 2.0 may contain 1.3 or lower)

@daipom
Copy link
Contributor Author

daipom commented Feb 17, 2023

Sorry, I misunderstood the operator ~>.
I thought ~> 1.4 is almost >= 1.4 and < 1.5, but it was wrong.

https://thoughtbot.com/blog/rubys-pessimistic-operator

Thanks for the advise! I will use ~> 1.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants