Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for query params in in_http input plugin #3188

Closed
omerlh opened this issue Nov 30, 2020 · 2 comments · Fixed by #3197
Closed

Add support for query params in in_http input plugin #3188

omerlh opened this issue Nov 30, 2020 · 2 comments · Fixed by #3197
Labels
feature request *Deprecated Label* Use enhancement label in general

Comments

@omerlh
Copy link
Contributor

omerlh commented Nov 30, 2020

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.

Is your feature request related to a problem? Please describe.

I am using fluentd to collect CSP violation report, I would like to add query params, like the website version to help us quickly spot issues related to a release.

Describe the solution you'd like

Add a property like add_query_params, that when set will parse the query params and add them to the record.

Describe alternatives you've considered

Passing it using a path and parsing the path with regex

Additional context

I'm willing to open a PR if the solution is acceptable

@kenhys kenhys added the feature request *Deprecated Label* Use enhancement label in general label Dec 1, 2020
@repeatedly
Copy link
Member

LGTM. Patches are welcome 👍

@omerlh
Copy link
Contributor Author

omerlh commented Dec 10, 2020

Awesome! Opened a PR to add it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request *Deprecated Label* Use enhancement label in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants