From bbc83bc2151e44d450a01bcd7ca76a08124c4e48 Mon Sep 17 00:00:00 2001 From: Daijiro Fukuda Date: Wed, 31 Jan 2024 12:33:37 +0900 Subject: [PATCH] in_tail: Remove old comments The comments was added in 76f246ae6a5a543c2b302b1a1f61a4223be177eb. At that time, closing was done by event-loop. Now, the situation is completely different. Currently, there are comments about the `close_io` option in `shutdown()` and `close()`. So, it would be enough to remove these comments. Signed-off-by: Daijiro Fukuda --- lib/fluent/plugin/in_tail.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/fluent/plugin/in_tail.rb b/lib/fluent/plugin/in_tail.rb index 514799a581..2b1c6d448e 100644 --- a/lib/fluent/plugin/in_tail.rb +++ b/lib/fluent/plugin/in_tail.rb @@ -584,10 +584,6 @@ def update_watcher(tail_watcher, pe, new_inode) detach_watcher_after_rotate_wait(tail_watcher, pe.read_inode) end - # TailWatcher#close is called by another thread at shutdown phase. - # It causes 'can't modify string; temporarily locked' error in IOHandler - # so adding close_io argument to avoid this problem. - # At shutdown, IOHandler's io will be released automatically after detached the event loop def detach_watcher(tw, ino, close_io = true) if @follow_inodes && tw.ino != ino log.warn("detach_watcher could be detaching an unexpected tail_watcher with a different ino.",