specify binary mode

fluent · Sep 29, 2015 · b4726df · b4726df
1 parent 4448361
commit b4726df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/fluent/plugin/out_file.rb b/lib/fluent/plugin/out_file.rb
@@ -83,11 +83,11 @@ def write(chunk)
 
       case @compress
       when nil
-        File.open(path, "a", DEFAULT_FILE_PERMISSION) {|f|
+        File.open(path, "ab", DEFAULT_FILE_PERMISSION) {|f|
           chunk.write_to(f)
         }
       when :gz
-        File.open(path, "a", DEFAULT_FILE_PERMISSION) {|f|
+        File.open(path, "ab", DEFAULT_FILE_PERMISSION) {|f|
           gz = Zlib::GzipWriter.new(f)
           chunk.write_to(gz)
           gz.close

diff --git a/test/plugin/test_out_file.rb b/test/plugin/test_out_file.rb
@@ -121,7 +121,7 @@ def check_gzipped_result(path, expect)
     # Zlib::GzipReader has a bug of concatenated file: https://bugs.ruby-lang.org/issues/9790
     # Following code from https://www.ruby-forum.com/topic/971591#979520
     result = ''
-    File.open(path) { |io|
+    File.open(path, "rb") { |io|
       loop do
         gzr = Zlib::GzipReader.new(io)
         result << gzr.read