Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-plugin-prometheus-2.0.3 breaks with fluent/fluentd:v1.15.1-1.0 (Async version incompatibility?) #340

Closed
thomas315 opened this issue Aug 2, 2022 · 2 comments · Fixed by #341

Comments

@thomas315
Copy link

Hello,

my specs:
fluent/fluentd:v1.15.1-1.0
fluent-plugin-prometheus-2.0.3

Latest version seems to not be compatible with fluentd anymore.

I'm getting following error message:

{"time":"2022-08-02T13:40:22.517736585+0000","level":"error","message":"unexpected error error_class=ArgumentError error="unknown keyword: :logger"","worker_id":0}
{"time":"2022-08-02T13:40:22.517848504+0000","level":"error","worker_id":0,"message":"/usr/lib/ruby/gems/3.1.0/gems/async-2.0.3/lib/async/scheduler.rb:39:in initialize'\n/usr/lib/ruby/gems/3.1.0/gems/async-2.0.3/lib/async/reactor.rb:32:in initialize'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/plugin_helper/http_server/server.rb:41:in new'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/plugin_ helper/http_server/server.rb:41:in initialize'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/plugin_helper/http_server.rb:69:in new'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/plugin_helper/http_server.rb:69:in http_server_create_http_server'\n/usr/lib/ruby/gems/3.1.0/gems/fluent-plugin-prometheus-2.0.3/lib/fluent/plugin/in_prometheus.rb:109:in start'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd- 1.15.1/lib/fluent/root_agent.rb:203:in block in start'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/root_agent.rb:192:in block (2 levels) in lifecycle'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/root_agent.rb:191:in each'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/root_agent.rb:191:in block in lifecycle'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/root_agent.rb:1 78:in each'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/root_agent.rb:178:in lifecycle'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/root_agent.rb:202:in start'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/engine.rb:248:in start'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/engine.rb:147:in run'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/supervisor.rb:
760:in block in run_worker'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/supervisor.rb:1036:in main_process'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/supervisor.rb:751:in run_worker'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/lib/fluent/command/fluentd.rb:386:in <top (required)>'\ninternal:/usr/lib/ruby/3.1.0/rubygems/core_ext/kernel_require.rb:85:in require'\n<internal:/usr/lib/ru by/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in require'\n/usr/lib/ruby/gems/3.1.0/gems/fluentd-1.15.1/bin/fluentd:15:in <top (required)>'\n/usr/bin/fluentd:25:in load'\n/usr/bin/fluentd:25:in `

'"}

I found related issues that might explain the error:
In fluentd's dependency management "async" should not be used with v2
fluent/fluentd#3592

In fluentd-docker-image the async-http version was updated and needs async v2 now as mentioned in above issue.
gem install async-http -v 0.56.6
dd348f2

So I'm not sure if the prometheus plugin needs to be fixed or if the latest fluentd image should not increase the async-http version too much.
If I customize fluent/fluentd:v1.15.1-1.0 myself by uninstalling async-http and installing async-http:0.54.0 everything works fine.

@ashie ashie transferred this issue from fluent/fluent-plugin-prometheus Aug 2, 2022
@ashie ashie closed this as completed in #341 Aug 3, 2022
@ashie
Copy link
Member

ashie commented Aug 3, 2022

Thanks for your report!
It's out docker image's fault, so we are now rebuilding it.
Please wait for a while to complete it.

@ashie
Copy link
Member

ashie commented Aug 3, 2022

Completed to build & upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants