-
Notifications
You must be signed in to change notification settings - Fork 1.8k
in_udp: Add a capability to inject source IP #7673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
7d6c6d1 to
3503b25
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
|
@leonardo-albertovich pls review |
|
cc: @lecaros docs |
--------- Signed-off-by: Hiroshi Hatake <[email protected]>
|
This is great, but for some reason it only works with format json and not format none. Is there a way to also insert the source ip with format none set? |
|
You should either open a new improvement request issue or even better a pull request to add the missing part of the feature. If you decide to give the PR and need some guidance feel free to contact me on slack. All of the required code is already in the plugin so it should be a matter of adding less than 10 lines total and it should be an easy entry point if you're interesting in contributing to the project in the future. |
@leonardo-albertovich Thanks for your reply. Indeed it wasn't too difficult, although it's been a while since I've been looking at C code :-) Maybe you could review it? #11160 |
|
Dang, as the MK2 announcer would say "Outstanding!" |
Currently, in_udp plugin does not offer adding source address feature.
This PR provides this feature.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Initially added documentation which corresponds to fluent/fluent-bit-docs#1165
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.