Merged
Conversation
Signed-off-by: Leonardo Alminana <leonardo.alminana@chronosphere.io>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
leonardo-albertovich
had a problem deploying
to
pr
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in the plugin proxy, the regular plugin destruction process counts on the name (and description) being constants, however, the plugin proxy makes copies of them when creating both plugin spec instances.
ToDo: I don't really understand why does the plugin proxy create two instances of the
flb_output_plugin/flb_input_pluginstructure so I need to check with the code owner to get a better understanding of the reasoning behind it.