Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.1 #16

Closed
2 tasks done
fujimotos opened this issue Feb 4, 2022 · 5 comments
Closed
2 tasks done

Add support for Ruby 3.1 #16

fujimotos opened this issue Feb 4, 2022 · 5 comments
Assignees

Comments

@fujimotos
Copy link
Collaborator

fujimotos commented Feb 4, 2022

Introduction

We are plannning to bundle fluent-plugin-windows-exporter in TD Agent,
starting from the next version (the release date will be March 2022).

Since TD Agent is now moving to Ruby 3.x, we also need to confirm that
this plugin works on Ruby 3.1 as well.

Task

  • Add Ruby 3.1 to GitHub Actions CI.
    • Use matrix notation to test both on 2.7 and 3.1.
    • Here is an example
  • Fix anything that are not compatible with Ruby 3.x.

Strategic priority

See fluent/fluentd#3585 for migration status.

@daipom
Copy link
Contributor

daipom commented Feb 15, 2022

@fujimotos
Thank you for the clear assignment.

https://github.com/fluent-plugins-nursery/fluent-plugin-windows-exporter/actions/runs/1845181374

I have added Ruby 3.1 in the add-ci-support-ruby31 branch
and all tests have passed in Ruby 3.1.

Would merging this into master complete this task?

@fujimotos
Copy link
Collaborator Author

@daipom Thank you! Marged via 6e3833d.

@daipom
Copy link
Contributor

daipom commented Feb 15, 2022

Thank you for merging!

@fujimotos
Copy link
Collaborator Author

Addendum: I documented the supported Ruby version in 8c9ad68.

@daipom
Copy link
Contributor

daipom commented Feb 15, 2022

Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants