Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Improvements and fixes for deals flow BREAKING CHANGE: different way of storing service interfaces and merged all configs into one fluence.yaml [fixes DXJ-308] #172

Merged
merged 6 commits into from
Feb 23, 2023
Merged

feat!: Improvements and fixes for deals flow BREAKING CHANGE: different way of storing service interfaces and merged all configs into one fluence.yaml [fixes DXJ-308] #172

merged 6 commits into from
Feb 23, 2023

Conversation

shamsartem
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Feb 22, 2023

DXJ-308 Improvements and fixes for deals flow

@shamsartem shamsartem self-assigned this Feb 22, 2023
@shamsartem
feat!: Improvements and fixes for deals flow
4bd7346 
BREAKING CHANGE: different way of storing service interfaces and merged all configs into one fluence.yaml [fixes DXJ-308]
@shamsartem shamsartem changed the title feat: Improvements and fixes for deals flow [fixes DXJ-308] feat!: Improvements and fixes for deals flow BREAKING CHANGE: different way of storing service interfaces and merged all configs into one fluence.yaml [fixes DXJ-308] Feb 22, 2023
@shamsartem shamsartem marked this pull request as ready for review February 22, 2023 23:53
coder11
coder11 suggested changes Feb 23, 2023
View reviewed changes
src/lib/helpers/jsToAqua.ts Show resolved Hide resolved
src/commands/aqua/json.ts Outdated Show resolved Hide resolved
src/commands/aqua/yml.ts Outdated Show resolved Hide resolved
coder11
coder11 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@coder11 coder11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you,

src/commands/aqua/json.ts Show resolved Hide resolved
@shamsartem shamsartem merged commit e07ad4d into main Feb 23, 2023
@shamsartem shamsartem deleted the DXJ-308 branch February 23, 2023 13:59
@fluencebot fluencebot mentioned this pull request Feb 23, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder11 coder11 coder11 approved these changes

@folex folex Awaiting requested review from folex

Assignees

@shamsartem shamsartem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamsartem @coder11