Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update spell template [fixes DXJ-514] #587

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: update spell template [fixes DXJ-514] #587

merged 1 commit into from
Oct 25, 2023

Conversation

shamsartem
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 25, 2023

DXJ-514 Use `Spell.store_log` in `fluence spell new` template

rn fluence spell new produces a spell.aqua that uses legacy log api:

Spell.list_push_string("logs", str)

This should be changed to

Spell.store_log(str)

@shamsartem shamsartem self-assigned this Oct 25, 2023
@shamsartem shamsartem added the e2e label Oct 25, 2023
@shamsartem shamsartem enabled auto-merge (squash) October 25, 2023 09:49
@shamsartem shamsartem merged commit 7560514 into main Oct 25, 2023
13 checks passed
@shamsartem shamsartem deleted the update-default-spell branch October 25, 2023 10:00
@fluencebot fluencebot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justprosh justprosh justprosh approved these changes

Assignees

@shamsartem shamsartem

Labels
e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamsartem @justprosh