Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint 9 #59

Closed
reosarevok opened this issue Jun 15, 2024 · 1 comment · Fixed by #60
Closed

Support eslint 9 #59

reosarevok opened this issue Jun 15, 2024 · 1 comment · Fixed by #60

Comments

@reosarevok
Copy link
Contributor

Trying to run no-flow-suppressions-in-strict-files (at least) with eslint 9 fails:

Oops! Something went wrong! :(

ESLint: 9.0.0

TypeError: Error while loading rule 'ft-flow/no-flow-suppressions-in-strict-files': context.getAllComments is not a function

This should use sourceCode.getAllComments() now - see https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
There might be other changes needed.

@Brianzchen
Copy link
Member

Hey thanks for raising. This was the only instance of getAllComments() that was missing getSourceCode.

Your issue should be fixed on version v3.0.10 though I cannot guarantee that this plugin completely works on eslint v9 so please keep raising if you find any other issues. A lot of the test infra needs to be overhauled to test against eslint v9 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants