Skip to content

Commit

Permalink
.gitignore for *.lock for people using yarn
Browse files Browse the repository at this point in the history
  • Loading branch information
@nmccready
nmccready committed Oct 28, 2016
1 parent 0290827 commit 25f5778
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ node_modules
reports
*.tgz
.idea
*.lock

3 comments on commit 25f5778

@vdh
Copy link

@vdh vdh commented on 25f5778 Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not supposed to ignore lock files, you're supposed to commit them.

@nmccready
Copy link
Collaborator Author

@nmccready nmccready commented on 25f5778 Feb 14, 2017 via email •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdh
Copy link

@vdh vdh commented on 25f5778 Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just saying it's very contrary to the whole point of using Yarn. yarn.lock is only used by Yarn, it has no effect on anyone still using NPM. They both make use of package.json in the same way. But with a yarn.lock file, Yarn can more accurately install the exact same files that were installed when the lock file was generated. It's to reduce "works on my machine" errors.

Please sign in to comment.