Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem - EDIT: Player Enhancements #37

Closed
Blitz077 opened this issue Dec 21, 2023 · 6 comments
Closed

Problem - EDIT: Player Enhancements #37

Blitz077 opened this issue Dec 21, 2023 · 6 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@Blitz077
Copy link

Blitz077 commented Dec 21, 2023

Why when i go out of the app while a video is playing it has to reload again once reopened and also can you make the video bar has time spent not time until it ends and a limit for buffering with options and also make us able to change the bar color and make the episode list horizontal not vertical . Wow thats a lot lol

@rhenwinch
Copy link
Collaborator

Why when i go out of the app while a video is playing it has to reload again once reopened

The video player - Media3 (aka ExoPlayer) - is releasing all the resources it recently used causing the player to reload the source again to fetch the video you're watching.

If I disable this feature, this could probably mean that it could hog or leak some of the phone's memory if ever you forget to force close or remove the app from the task manager/recents list.

though, we could add another settings option for this.

can you make the video bar has time spent not time until it ends

already added this one on the new upcoming update!

a limit for buffering with options

lastly, may I ask if u could elaborate more about this feature?

@rhenwinch
Copy link
Collaborator

make the episode list horizontal not vertical

I made big changes to the player ui btw. including this one. here's the sample preview:
new episodes list layout

@rhenwinch rhenwinch added enhancement New feature or request question Further information is requested labels Dec 22, 2023
@rhenwinch
Copy link
Collaborator

lastly, could u pls edit the title to be more specific about the issue. big thanks 💯

@Blitz077
Copy link
Author

If by memory you mean ram then dont worry i have 8 gb and for the buffering i mean like it buffers for a certain time ahead from the moment youre watching i want us to have the ability to control the time it can buffer ahead so if per say it buffers a full minute ahead and then i go back like 5 secs it will do the buffering again and consume more internet

@Blitz077
Copy link
Author

lastly, could u pls edit the title to be more specific about the issue. big thanks 💯

What should it be we discussed a lot of stuff 😂

@rhenwinch
Copy link
Collaborator

If by memory you mean ram then dont worry i have 8 gb and for the buffering i mean like it buffers for a certain time ahead from the moment youre watching i want us to have the ability to control the time it can buffer ahead so if per say it buffers a full minute ahead and then i go back like 5 secs it will do the buffering again and consume more internet

Ahh I see. Adding this as a feature for the next update since the next update has been all about the player

@rhenwinch rhenwinch changed the title Problem Problem - EDIT: Player Enhancements Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants